Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752672Ab3EJNBl (ORCPT ); Fri, 10 May 2013 09:01:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46155 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751785Ab3EJNBk (ORCPT ); Fri, 10 May 2013 09:01:40 -0400 Date: Fri, 10 May 2013 14:58:26 +0200 From: Oleg Nesterov To: Lucas De Marchi Cc: linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH 3/3] init/Kconfig: Add option to set modprobe command Message-ID: <20130510125826.GA553@redhat.com> References: <1368159316-31744-1-git-send-email-lucas.de.marchi@gmail.com> <1368159316-31744-3-git-send-email-lucas.de.marchi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1368159316-31744-3-git-send-email-lucas.de.marchi@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 528 Lines: 15 On 05/10, Lucas De Marchi wrote: > > -char modprobe_path[KMOD_PATH_LEN] = "/sbin/modprobe -q --"; > +char modprobe_path[KMOD_PATH_LEN] = CONFIG_DEFAULT_MODULE_LOAD_BIN; But even after 1/3 and 2/3 this can break free_modprobe_argv() ? It assumes that argv[3] is module_name. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/