Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757591Ab3EJPb4 (ORCPT ); Fri, 10 May 2013 11:31:56 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:39220 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753231Ab3EJPby (ORCPT ); Fri, 10 May 2013 11:31:54 -0400 Date: Fri, 10 May 2013 17:31:50 +0200 From: Frederic Weisbecker To: Borislav Petkov Cc: Ingo Molnar , Jiri Kosina , Tony Luck , linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: NOHZ: WARNING: at arch/x86/kernel/smp.c:123 native_smp_send_reschedule Message-ID: <20130510153148.GA9358@somewhere> References: <20130510002930.GB2394@somewhere> <20130510092811.GA22942@pd.tnic> <20130510093729.GA16487@gmail.com> <20130510094556.GA23014@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130510094556.GA23014@pd.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 942 Lines: 35 On Fri, May 10, 2013 at 11:45:56AM +0200, Borislav Petkov wrote: > On Fri, May 10, 2013 at 11:37:29AM +0200, Ingo Molnar wrote: > > The pattern I use in such cases is: > > > > if (WARN_ONCE(!cpu_online(cpu))) { > > printk("%d %d\n", cpu, smp_processor_id()); > > dump_stack(); > > } > > Cool, and WARN_ONCE dumps stack already so: > > if (WARN_ONCE(!cpu_online(cpu))) > printk("%d %d\n", cpu, smp_processor_id()); Even better: if (WARN_ONCE(!cpu_online(cpu))) printk_once("%d %d\n", cpu, smp_processor_id()); So the printk doesn't flood after the first case. > > Nice. > > -- > Regards/Gruss, > Boris. > > Sent from a fat crate under my desk. Formatting is fine. > -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/