Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756833Ab3EJREO (ORCPT ); Fri, 10 May 2013 13:04:14 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:51504 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754678Ab3EJREM (ORCPT ); Fri, 10 May 2013 13:04:12 -0400 Date: Fri, 10 May 2013 10:03:24 -0700 From: Andrew Morton To: "Rafael J. Wysocki" Cc: Robin Holt , "Srivatsa S. Bhat" , "H. Peter Anvin" , Russ Anderson , Russell King , Guan Xuetao , Linux Kernel Mailing List , the arch/x86 maintainers , Arm Mailing List , stable@vger.kernel.org Subject: Re: [PATCH -v8 01/11] CPU hotplug: Provide a generic helper to disable/enable CPU hotplug Message-Id: <20130510100324.e1e066ab.akpm@linux-foundation.org> In-Reply-To: <1651579.orCh9JNVz6@vostro.rjw.lan> References: <1367937595-32241-1-git-send-email-holt@sgi.com> <1367937595-32241-2-git-send-email-holt@sgi.com> <20130509150121.8c3ef60b2fc748ce542a1a52@linux-foundation.org> <1651579.orCh9JNVz6@vostro.rjw.lan> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 812 Lines: 22 On Fri, 10 May 2013 13:11:51 +0200 "Rafael J. Wysocki" wrote: > ... > > > cpu_hotplug_disable() doesn't get compiled unless we've defined > > CONFIG_PM_SLEEP_SMP. I cannot begin to imagine what the logic is > > behind that! > > I suppose it was only used by suspend/hibernate code paths when this was > introduced. OK, well I suspect that what I have now is simply wrong for Robin's application. Robin, can you please check this? We probably want to make the does-something version of cpu_hotplug_disable/enable available if CONFIG_HOTPLUG_CPU. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/