Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753379Ab3EJSzK (ORCPT ); Fri, 10 May 2013 14:55:10 -0400 Received: from mail-ie0-f181.google.com ([209.85.223.181]:64007 "EHLO mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753232Ab3EJSzG (ORCPT ); Fri, 10 May 2013 14:55:06 -0400 Date: Fri, 10 May 2013 11:05:27 -0700 From: Anton Vorontsov To: Xiong Zhou Cc: Lars-Peter Clausen , dwmw2@infradead.org, linux-next@vger.kernel.org, Stephen Rothwell , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH -next] power: fix bq27x00_battery kconfig Message-ID: <20130510180527.GA32333@teo> References: <51838C3E.5090303@metafoo.de> <5184E2CD.8040900@metafoo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1761 Lines: 45 On Tue, May 07, 2013 at 10:15:56AM +0800, Xiong Zhou wrote: > From: Xiong Zhou > > This patch fixes build failure(randconfig) of next-20130501. > When config I2C as m, BATTERY_BQ27x00 as y, here comes the failure. > The driver depends on I2C only if I2C is not disabled, as Lars > commented. Last version of this patch make the driver depend on I2C > unconditionally. > > Failure message: > drivers/built-in.o: In function `bq27x00_read_i2c': > bq27x00_battery.c:(.text+0x1082a7): undefined reference to `i2c_transfer' > drivers/built-in.o: In function `bq27x00_battery_init': > bq27x00_battery.c:(.init.text+0x6085): undefined reference to `i2c_register_driver' > bq27x00_battery.c:(.init.text+0x60c7): undefined reference to `i2c_del_driver' > drivers/built-in.o: In function `bq27x00_battery_exit': > bq27x00_battery.c:(.exit.text+0xbf0): undefined reference to `i2c_del_driver' > make: *** [vmlinux] Error 1 > > Signed-off-by: Xiong Zhou > Cc: Lars-Peter Clausen > --- Applied, thanks! > drivers/power/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig > index 0d0b5d7..f11bacd 100644 > --- a/drivers/power/Kconfig > +++ b/drivers/power/Kconfig > @@ -152,6 +152,7 @@ config BATTERY_SBS > > config BATTERY_BQ27x00 > tristate "BQ27x00 battery driver" > + depends on I2C || I2C=n > help > Say Y here to enable support for batteries with BQ27x00 (I2C/HDQ) chips. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/