Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751376Ab3EKE20 (ORCPT ); Sat, 11 May 2013 00:28:26 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:54041 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750888Ab3EKE2Y (ORCPT ); Sat, 11 May 2013 00:28:24 -0400 Message-ID: <518DC8E6.5000606@nvidia.com> Date: Fri, 10 May 2013 22:28:22 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: Christian Daudt CC: Grant Likely , Rob Herring , Rob Landley , Russell King , Chris Ball , Olof Johansson , Greg Kroah-Hartman , Wei WANG , Ludovic Desroches , Arnd Bergmann , "Mike A. Chan" , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, csd_b@daudt.org Subject: Re: [PATCH] ARM: mmc: bcm281xx SDHCI driver References: <1368078942-31265-1-git-send-email-csd@broadcom.com> In-Reply-To: <1368078942-31265-1-git-send-email-csd@broadcom.com> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1165 Lines: 27 On 05/08/2013 11:55 PM, Christian Daudt wrote: > Add SDHCI driver for the Broadcom 281xx SoCs. Also > add bindings for it into bcm281xx dts files. > Still missing: > - power managemement > diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c > + /* > + * Back-to-Back register write needs a delay of 1ms at bootup (min 10uS) > + * Back-to-Back writes to same register needs delay when SD bus clock > + * is very low w.r.t AHB clock, mainly during boot-time and during card > + * insert-removal. > + */ > + udelay(1000); > + sdhci_writel(host, val, KONA_SDHOST_CORECTRL); This sounds very similar to the workaround in drivers/mmc/host/sdhci-bcm2835.c. Is this the same IP block supported by that driver? Perhaps not, since bcm2835 apparently needs other WARs such as always using 32-bit IO and hence needing custom read/write w/b functions to do read-modify-write which isn't here? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/