Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753308Ab3EKPcB (ORCPT ); Sat, 11 May 2013 11:32:01 -0400 Received: from mail-ea0-f169.google.com ([209.85.215.169]:63601 "EHLO mail-ea0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753064Ab3EKPb7 (ORCPT ); Sat, 11 May 2013 11:31:59 -0400 Date: Sat, 11 May 2013 17:31:43 +0200 From: Richard Cochran To: Dong Zhu Cc: Jeff Kirsher , Jesse Brandeburg , Bruce Allan , Carolyn Wyborny , Don Skidmore , Greg Rose , Peter P Waskiewicz Jr , Alex Duyck , John Ronciak , Tushar Dave , Matthew Vick , Jacob Keller , "Paul E. McKenney" , David Howells , Dave Jones , Thomas Gleixner , linux-kernel@vger.kernel.org, e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org Subject: Re: [PATCH] igb: add a method to get the nic hw time stamping policy Message-ID: <20130511153143.GA25180@netboy> References: <20130511140219.GG8399@zhudong.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130511140219.GG8399@zhudong.nay.redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 763 Lines: 26 On Sat, May 11, 2013 at 10:02:19PM +0800, Dong Zhu wrote: > > Currently kernel only support setting the hw time stamping policy > through ioctl,now add a method to check which packets(Outgoing and > Incoming) are time stamped by nic. I don't really see a use case here. Applications needing time stamping should just set the policy that they need. > struct hwtstamp_config { > + int rw; Also, you can't just go adding fields to an ioctl. > int flags; > int tx_type; > int rx_filter; > -- Thanks, Richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/