Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753004Ab3EKPsd (ORCPT ); Sat, 11 May 2013 11:48:33 -0400 Received: from terminus.zytor.com ([198.137.202.10]:47848 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752098Ab3EKPsc (ORCPT ); Sat, 11 May 2013 11:48:32 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <20130511130457.GD18614@n2100.arm.linux.org.uk> References: <1368273447-11958-1-git-send-email-holt@sgi.com> <1368273447-11958-10-git-send-email-holt@sgi.com> <20130511130457.GD18614@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH -v10 09/11] arm, prepare reboot_mode for moving to generic kernel code. From: "H. Peter Anvin" Date: Sat, 11 May 2013 08:47:28 -0700 To: Russell King - ARM Linux , Robin Holt CC: Andrew Morton , Russ Anderson , the arch/x86 maintainers , Linux Kernel Mailing List , Guan Xuetao , Arm Mailing List Message-ID: <588ed084-fed7-4bd9-bcd7-a32f40bd404a@email.android.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1830 Lines: 52 By the way, do we really need Yoda programming here? Russell King - ARM Linux wrote: >On Sat, May 11, 2013 at 06:57:25AM -0500, Robin Holt wrote: >> This patch prepares for the moving the parsing of reboot= to the >generic >> kernel code by making reboot_mode into a more generic form. >> >> Signed-off-by: Robin Holt >> To: Andrew Morton >> To: Russell King >> Cc: Russ Anderson >> Cc: Robin Holt >> Cc: H. Peter Anvin >> Cc: Guan Xuetao >> Cc: Linux Kernel Mailing List >> Cc: the arch/x86 maintainers >> Cc: Arm Mailing List > >Almost-but-not-quite-Acked-by: Russell King > :) > >> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c >> index f219703..92b47df 100644 >> --- a/arch/arm/kernel/process.c >> +++ b/arch/arm/kernel/process.c >> @@ -174,14 +174,14 @@ void arch_cpu_idle(void) >> default_idle(); >> } >> >> -static char reboot_mode = 'h'; >> +enum reboot_mode reboot_mode = REBOOT_HARD; >> >> -int __init reboot_setup(char *str) >> +static int __init reboot_setup(char *str) >> { >> - reboot_mode = str[0]; >> + if ('s' == str[0]) >> + reboot_mode = REBOOT_SOFT; > >Remember we talked about the 'gpio' mode as well, so you also need here >+ if ('g' == str[0]) > reboot_mode = REBOOT_GPIO; -- Sent from my mobile phone. Please excuse brevity and lack of formatting. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/