Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754616Ab3EKVkh (ORCPT ); Sat, 11 May 2013 17:40:37 -0400 Received: from mail-lb0-f178.google.com ([209.85.217.178]:43895 "EHLO mail-lb0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754353Ab3EKVkg (ORCPT ); Sat, 11 May 2013 17:40:36 -0400 MIME-Version: 1.0 In-Reply-To: <000001ce4e1e$d1cc5de0$756519a0$@samsung.com> References: <000001ce4e1e$d1cc5de0$756519a0$@samsung.com> Date: Sat, 11 May 2013 14:40:34 -0700 X-Google-Sender-Auth: 6qQBwRUBu9XSaoJLDtfF_Zq7XQM Message-ID: Subject: Re: [PATCH] ARM: dts: add pin state information for DP HPD support to Exynos5250 From: Doug Anderson To: Jingoo Han Cc: Kukjin Kim , linux-samsung-soc , Thomas Abraham , Olof Johansson , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Sean Paul , =?ISO-8859-1?Q?St=E9phane_Marchesin?= , Andrew Bresticker Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2142 Lines: 57 Jingoo, On Sat, May 11, 2013 at 1:09 AM, Jingoo Han wrote: > Add pin state information for DP HPD support that requires > pin configuration support using pinctrl interface. > > Signed-off-by: Jingoo Han > --- > Tested on Exynos5250 > > arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 7 +++++++ > arch/arm/boot/dts/exynos5250-smdk5250.dts | 3 +++ > 2 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi > index d1650fb..e9cdee3 100644 > --- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi > +++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi > @@ -553,6 +553,13 @@ > samsung,pin-pud = <0>; > samaung,pin-drv = <0>; > }; > + > + dp_hpd: dp_hpd { > + samsung,pins = "gpx0-7"; > + samsung,pin-function = <3>; > + samsung,pin-pud = <0>; > + samaung,pin-drv = <0>; > + }; > }; > > pinctrl@13400000 { > diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts > index 3e0c792..d53ea34 100644 > --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts > +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts > @@ -224,6 +224,9 @@ > samsung,color-depth = <1>; > samsung,link-rate = <0x0a>; > samsung,lane-count = <4>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&dp_hpd>; I was going to suggest moving this to exynos5250.dtsi but then realized that I saw a board recently that used a non-standard HPD pin recently! ...so keeping it in the board file (like you've done) is good. ...so looks good to me. Reviewed-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/