Date: Mon, 13 May 2013 09:53:27 +0000 (GMT)
From: EUNBONG SONG <eunb.song@samsung.com>
Subject: Re: Re: Re: EXT4 panic at jbd2_journal_put_journal_head() in 3.9+
To: Zheng Liu <gnehzuil.liu@gmail.com>, Tony Luck <tony.luck@gmail.com>
Cc: Dmitry Monakhov <dmonakhov@openvz.org>, "Theodore Ts'o" <tytso@mit.edu>,
        "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Reply-to: eunb.song@samsung.com
MIME-version: 1.0
Msgkey: 20130513095010510@eunb.song
Content-type: text/plain; charset=euc-kr
MIME-version: 1.0
Message-id: <12945098.35291368438804981.JavaMail.weblogic@epv6ml07>
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1317
Lines: 27


> Hi all,

> First of all I couldn't reproduce this regression in my sand box.  So
> the following speculation is only my guess.  I suspect that the commit
> (ae4647fb) isn't root cause.  It just uncover a potential bug that has
> been there for a long time.  I look at the code, and found two
> suspicious stuff in jbd2.  The first one is in do_get_write_access().
> In this function we forgot to lock bh state when we check b_jlist ==
> BJ_Shadow.  I generate a patch to fix it, and I really think it is the
> root cause.  Further, in __journal_remove_journal_head() we check
> b_jlist == BJ_None.  But, when this function is called, bh state won't
> be locked sometimes.  So I suspect this is why we hit a BUG in
> jbd2_journal_put_journal_head().  But I don't have a good solution to
> fix this until now because I don't know whether we need to lock bh state
> here, or maybe we should remove this assertation.
>
> So, generally, Tony, Eunbong, could you please try the following patch?
>
> Thanks in advance,
>                                                 - Zheng


Hi, I tested your patch. Unfortunately, the same problem was reproduced.
Thanks.
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?