Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753762Ab3EMODK (ORCPT ); Mon, 13 May 2013 10:03:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9792 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751891Ab3EMODJ (ORCPT ); Mon, 13 May 2013 10:03:09 -0400 Date: Mon, 13 May 2013 15:59:47 +0200 From: Oleg Nesterov To: Lucas De Marchi , Andrew Morton , Rusty Russell Cc: lkml Subject: Re: [PATCH 3/3] init/Kconfig: Add option to set modprobe command Message-ID: <20130513135947.GA1613@redhat.com> References: <1368159316-31744-1-git-send-email-lucas.de.marchi@gmail.com> <1368159316-31744-3-git-send-email-lucas.de.marchi@gmail.com> <20130510125826.GA553@redhat.com> <20130510153638.GA8179@redhat.com> <20130510171054.GA27479@redhat.com> <20130510173511.GA28490@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1530 Lines: 41 On 05/10, Lucas De Marchi wrote: > > On Fri, May 10, 2013 at 2:35 PM, Oleg Nesterov wrote: > > On 05/10, Oleg Nesterov wrote: > >> > >> > > -char modprobe_path[KMOD_PATH_LEN] = "/sbin/modprobe"; > >> > > +char modprobe_path[KMOD_PATH_LEN] = "/sbin/modprobe -q --"; > >> > >> No. This is incompatible change, we shouldn't do this. > > > > Exactly. This can break a distro which writes to sys/kernel/modprobe. > > > > And if we do not do this, you can simply make a single trivial patch > > which does ... > > that it all. (or perhaps a kernel parameter makes more sense). > > > > Yes, this doesn't allow to pass the additional arguments, but is it > > that important? > > Yes, because I don't want to simply change the binary to use, I want > to be able to use a general "kmod" binary that accept a command like > "load". Next version of kmod will accept things like this (see the > commit message in patch 3/3): Well, but a link to the binary which checks argv[0] or a trivial executable which simply execs "kmod load" looks like the simple workaround. And this doesn't need to recompile the kernel. Lucas, I simply do not know... Andrew, Rusty, what do you think? Can we do the change above? Do we really want CONFIG_MODPROBE_PATH or a kernel parameter ? Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/