Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752689Ab3EMOT7 (ORCPT ); Mon, 13 May 2013 10:19:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16554 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751071Ab3EMOT6 (ORCPT ); Mon, 13 May 2013 10:19:58 -0400 Date: Mon, 13 May 2013 16:16:33 +0200 From: Oleg Nesterov To: Lucas De Marchi Cc: lkml , Andrew Morton , Rusty Russell Subject: Re: [PATCH 3/3] init/Kconfig: Add option to set modprobe command Message-ID: <20130513141633.GB1613@redhat.com> References: <1368159316-31744-1-git-send-email-lucas.de.marchi@gmail.com> <1368159316-31744-3-git-send-email-lucas.de.marchi@gmail.com> <20130510125826.GA553@redhat.com> <20130510153638.GA8179@redhat.com> <20130510171054.GA27479@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1450 Lines: 43 On 05/11, Lucas De Marchi wrote: > > On Fri, May 10, 2013 at 2:10 PM, Oleg Nesterov wrote: > > > >> > -char modprobe_path[KMOD_PATH_LEN] = "/sbin/modprobe"; > >> > +char modprobe_path[KMOD_PATH_LEN] = "/sbin/modprobe -q --"; > > > > No. This is incompatible change, we shouldn't do this. > > But then what option do we have? I don't think any distro writing to > sysctl would stop working without "-q --". Who knows? Again, I won't argue, I simply do not know. But this is incompatible change. > And if they are indeed > using this during boot, I think they would be much safer to just > change to set this at compile time like this patch is trying to do. Personally I think that "compile time" is not the best choice, but I won't argue. > Otherwise, the options are really ugly: > > 1) always give "-q --" by putting this on the kasprintf() call: > kasprintf(GFP_KERNEL, "%s -q -- %s", modprobe_command, module_name). > 2) provide a proc_dostring_modprobe, which ensures "-q --" is appended > to the provided path Agreed, both options do not look nice. Lucas. I will be happy to resend the argv_split/call_modprobe changes, but I can't judge whether we can/want do this. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/