Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755190Ab3EMPh1 (ORCPT ); Mon, 13 May 2013 11:37:27 -0400 Received: from smtp.snhosting.dk ([87.238.248.203]:32023 "EHLO smtp.domainteam.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751368Ab3EMPh0 (ORCPT ); Mon, 13 May 2013 11:37:26 -0400 Date: Mon, 13 May 2013 17:37:21 +0200 From: Sam Ravnborg To: Laurent Navet Cc: davem@davemloft.net, daniel@gaisler.com, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arch: sparc: kernel: use devm_ioremap_resource() Message-ID: <20130513153721.GA18836@merkur.ravnborg.org> References: <1368367807-1263-1-git-send-email-laurent.navet@gmail.com> <20130512152829.GA17866@merkur.ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 970 Lines: 22 On Mon, May 13, 2013 at 01:43:17PM +0200, Laurent Navet wrote: > The same is done almost everywhere in kernel tree : > > e.g : > http://lxr.free-electrons.com/source/drivers/staging/iio/adc/mxs-lradc.c#L928 > http://lxr.free-electrons.com/source/drivers/gpio/gpio-mxs.c#L292 > http://lxr.free-electrons.com/source/drivers/iommu/tegra-smmu.c#L1181 > http://lxr.free-electrons.com/source/drivers/rtc/rtc-spear.c#L388 > http://lxr.free-electrons.com/source/drivers/i2c/busses/i2c-imx.c#L514 > http://lxr.free-electrons.com/source/sound/soc/kirkwood/kirkwood-i2s.c#L475 > > and so on... all theses functions return an int. I was confusing PTR_ERR() and ERR_PTR(), so path looks ok. Acked-by: Sam Ravnborg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/