Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754732Ab3EMTDE (ORCPT ); Mon, 13 May 2013 15:03:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3939 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754028Ab3EMTCy (ORCPT ); Mon, 13 May 2013 15:02:54 -0400 Date: Mon, 13 May 2013 22:02:50 +0300 From: "Michael S. Tsirkin" To: Luiz Capitulino Cc: Rafael Aquini , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, riel@redhat.com, amit.shah@redhat.com, anton@enomsg.org Subject: Re: [RFC 2/2] virtio_balloon: auto-ballooning support Message-ID: <20130513190250.GA2496@redhat.com> References: <1368111229-29847-1-git-send-email-lcapitulino@redhat.com> <1368111229-29847-3-git-send-email-lcapitulino@redhat.com> <20130509211516.GC16446@optiplex.redhat.com> <20130510092046.17be9bbb@redhat.com> <20130513143441.GA13910@optiplex.redhat.com> <20130513142511.3c2bde18@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130513142511.3c2bde18@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1177 Lines: 25 On Mon, May 13, 2013 at 02:25:11PM -0400, Luiz Capitulino wrote: > On Mon, 13 May 2013 11:34:41 -0300 > Rafael Aquini wrote: > > > You're right, and the host's member is used to communicate the configured size > > to guest's balloon device, however, by not changing it when the shrinker causes > > the balloon to deflate will make the balloon thread to be woken up again > > in order to chase the balloon size target again, won't it? Check > > I don't see the balloon thread waking up after the shrinker executes in my > testing. Maybe this is so because it will only wake up when QEMU notifies > a config change. Well that's also a problem. Need some mechanism to re-inflate balloon when guest memory pressure is down. virtio fs mechanism worth a look? > But anyway, I'll think how to improve this as suggested by Michael too, as > I seem to be changing num_pages' semantics according to the virtio spec. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/