Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754720Ab3EMTU4 (ORCPT ); Mon, 13 May 2013 15:20:56 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:47821 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753994Ab3EMTUz (ORCPT ); Mon, 13 May 2013 15:20:55 -0400 MIME-Version: 1.0 In-Reply-To: <1368472103-3427-1-git-send-email-cody@linux.vnet.ibm.com> References: <1368472103-3427-1-git-send-email-cody@linux.vnet.ibm.com> Date: Mon, 13 May 2013 22:20:53 +0300 X-Google-Sender-Auth: -amI7NfC-2nNs_YlkI8BhhOsDGE Message-ID: Subject: Re: [PATCH RESEND v3 00/11] mm: fixup changers of per cpu pageset's ->high and ->batch From: Pekka Enberg To: Cody P Schafer Cc: Andrew Morton , Gilad Ben-Yossef , Simon Jeons , KOSAKI Motohiro , Mel Gorman , Linux MM , LKML Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 879 Lines: 20 Hi Cody, On Mon, May 13, 2013 at 10:08 PM, Cody P Schafer wrote: > "Problems" with the current code: > 1. there is a lack of synchronization in setting ->high and ->batch in > percpu_pagelist_fraction_sysctl_handler() > 2. stop_machine() in zone_pcp_update() is unnecissary. > 3. zone_pcp_update() does not consider the case where percpu_pagelist_fraction is non-zero Maybe it's just me but I find the above problem description confusing. How does the problem manifest itself? How did you find about it? Why do we need to fix all three problems in the same patch set? Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/