Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756548Ab3ENHLk (ORCPT ); Tue, 14 May 2013 03:11:40 -0400 Received: from mail-la0-f42.google.com ([209.85.215.42]:52607 "EHLO mail-la0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756374Ab3ENHLg (ORCPT ); Tue, 14 May 2013 03:11:36 -0400 From: Dmitry Monakhov To: Eric Sandeen , Jan Kara Cc: "Theodore Ts'o" , EUNBONG SONG , "linux-ext4\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" , linux-xfs@vger.kernel.org, Dave Chinner Subject: Re: EXT4 regression caused 4eec7 In-Reply-To: <51911E42.7010008@redhat.com> References: <6719519.5821368147110937.JavaMail.weblogic@epml17> <20130510192747.GA11707@thunk.org> <87y5bm53z3.fsf@openvz.org> <87txm96fkd.fsf@openvz.org> <87mws1eq6y.fsf@openvz.org> <20130511230559.GD26298@thunk.org> <87a9o01siw.fsf@openvz.org> <51911604.2060805@redhat.com> <20130513170124.GJ400@quack.suse.cz> <51911E42.7010008@redhat.com> User-Agent: Notmuch/0.6.1 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-redhat-linux-gnu) Date: Tue, 14 May 2013 11:11:32 +0400 Message-ID: <874ne6xcgr.fsf@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1594 Lines: 35 On Mon, 13 May 2013 12:09:22 -0500, Eric Sandeen wrote: > On 5/13/13 12:01 PM, Jan Kara wrote: > > On Mon 13-05-13 11:34:12, Eric Sandeen wrote: > >> On 5/12/13 4:01 AM, Dmitry Monakhov wrote: > >>> In fact '4eec70' are vexing because I have reviewed and tested this patch before > >>> it was marked as Review-by, but missed the bug. This is because xfstests > >>> was executed manually logs was full of warnings but tainted flag was not > >>> checked at the end. > >> > >> Can you elaborate on this? What was logged, and is it something we could > >> try to pick up post-test in xfstests? > > Generally I think it might be useful if xfstests would fail / warn if > > kernel became tainted during the test (e.g. due to WARN_ON or oops, or > > something like that). It should be even relatively easy to implement > > (just compare /proc/sys/kernel/tainted before and after each test). > > > > Honza > > > > Ah, right. That should be easy, I'll see if I can cook that up. Also we can use abrt's kernel-oops handler to collect messages. > > Thanks, > -Eric > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/