Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756260Ab3ENHTJ (ORCPT ); Tue, 14 May 2013 03:19:09 -0400 Received: from bosmailout10.eigbox.net ([66.96.186.10]:57926 "EHLO bosmailout10.eigbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752446Ab3ENHTH (ORCPT ); Tue, 14 May 2013 03:19:07 -0400 X-Authority-Analysis: v=2.0 cv=dt1Z+ic4 c=1 sm=1 a=i0WiXTmbFXIwRF3IvSVw8w==:17 a=bc2JKO6qiGsA:10 a=FB6NmUnAAagA:10 a=MiQ8TEe4tdQA:10 a=8nJEP1OIZ-IA:10 a=flkWhlLGwC4A:10 a=bJ0fqD8TFZgqkSadqForXVIPBlU=:19 a=jAfPOIUMAAAA:8 a=jlq0EXAQOsoRBPeX1aoA:9 a=wPNLvfGTeEIA:10 a=gE_ZUhsuebIA:10 a=AnsiuLKgxXFeB68GILQVjQ==:117 X-EN-OrigOutIP: 10.20.18.14 X-EN-IMPSID: bjK31l00v0JCtq201jK3hC Message-ID: <5191E53B.9000106@yahoo.es> Date: Tue, 14 May 2013 15:18:19 +0800 From: Hein Tibosch User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 MIME-Version: 1.0 To: Jean-Christophe PLAGNIOL-VILLARD , Nicolas Ferre CC: michal.simek@xilinx.com, Ludovic Desroches , s.trumtrar@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net/macb: fix ISR clear-on-write behavior only for some SoC References: <1368461105-23128-1-git-send-email-nicolas.ferre@atmel.com> <51918C23.7040106@yahoo.es> <20130514055256.GD22508@game.jcrosoft.org> In-Reply-To: <20130514055256.GD22508@game.jcrosoft.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-EN-UserInfo: 3946c951b80c12a8be5482963a0b1232:e0ae43bc192b431f8b69f09a37527cbc X-EN-AuthUser: hein@htibosch.net X-EN-OrigIP: 114.79.60.61 X-EN-OrigHost: unknown Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1653 Lines: 49 On 5/14/2013 1:52 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 08:58 Tue 14 May , Hein Tibosch wrote: >> On 5/14/2013 12:05 AM, Jean-Christophe PLAGNIOL-VILLARD wrote: >>> On May 14, 2013, at 12:05 AM, Nicolas Ferre wrote: >>> >>>> Commit 749a2b6 (net/macb: clear tx/rx completion flags in ISR) >>>> introduces clear-on-write on ISR register. This behavior is not always >>>> implemented when using Cadence MACB/GEM and is breaking other platforms. >>>> We are using a new Device Tree compatibility string and a capability >>>> property to actually activate this clear-on-write behavior on ISR. >>>> >>>> Reported-by: Hein Tibosch >>>> Signed-off-by: Nicolas Ferre >>> can we detect it via the IP? >> This was my first proposal, have it based on the value of MACB's >> register 'MID' (offset 0x00fc, lower 16 bits). >> On avr32 it reads: 0x0000010D, on Zynq it reports 0x00000119 >> >> So for the moment, CAPS_ISR_CLEAR_ON_WRITE could be set if the revision >> equals to 0x00000119? > so no it will not work > > as the gem on sama5 is 00020119 > > so version 0x119 too > > nico All right, that's a pity. The only issue that remains then is the obligation to use CONFIG_OF, or: +#if defined(CONFIG_OF) + dev_id = of_match_device(macb_dt_ids, &pdev->dev); + if (dev_id) + bp->caps = (u32)dev_id->data; + +#endif ? Hein -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/