Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756290Ab3ENHWR (ORCPT ); Tue, 14 May 2013 03:22:17 -0400 Received: from 14.mo3.mail-out.ovh.net ([188.165.43.98]:42976 "EHLO mo3.mail-out.ovh.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752446Ab3ENHWQ convert rfc822-to-8bit (ORCPT ); Tue, 14 May 2013 03:22:16 -0400 Content-Type: text/plain; charset=US-ASCII Mime-Version: 1.0 (Mac OS X Mail 6.3 \(1503\)) X-Ovh-Mailout: 178.32.228.3 (mo3.mail-out.ovh.net) Subject: Re: [PATCH] net/macb: fix ISR clear-on-write behavior only for some SoC From: Jean-Christophe PLAGNIOL-VILLARD In-Reply-To: <5191E53B.9000106@yahoo.es> Date: Tue, 14 May 2013 15:22:05 +0800 Cc: Jean-Christophe PLAGNIOL-VILLARD , Nicolas Ferre , michal.simek@xilinx.com, Ludovic Desroches , s.trumtrar@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Content-Transfer-Encoding: 7BIT Message-Id: References: <1368461105-23128-1-git-send-email-nicolas.ferre@atmel.com> <51918C23.7040106@yahoo.es> <20130514055256.GD22508@game.jcrosoft.org> <5191E53B.9000106@yahoo.es> To: Hein Tibosch X-Mailer: Apple Mail (2.1503) X-Ovh-Tracer-Id: 16604490352277040118 X-Ovh-Remote: 180.154.95.251 () X-Ovh-Local: 213.186.33.20 (ns0.ovh.net) X-OVH-SPAMSTATE: OK X-OVH-SPAMSCORE: -100 X-OVH-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeeifedrjeejucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd X-Spam-Check: DONE|U 0.5/N X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeeifedrjeejucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2060 Lines: 62 On May 14, 2013, at 3:18 PM, Hein Tibosch wrote: > > On 5/14/2013 1:52 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: >> On 08:58 Tue 14 May , Hein Tibosch wrote: >>> On 5/14/2013 12:05 AM, Jean-Christophe PLAGNIOL-VILLARD wrote: >>>> On May 14, 2013, at 12:05 AM, Nicolas Ferre wrote: >>>> >>>>> Commit 749a2b6 (net/macb: clear tx/rx completion flags in ISR) >>>>> introduces clear-on-write on ISR register. This behavior is not always >>>>> implemented when using Cadence MACB/GEM and is breaking other platforms. >>>>> We are using a new Device Tree compatibility string and a capability >>>>> property to actually activate this clear-on-write behavior on ISR. >>>>> >>>>> Reported-by: Hein Tibosch >>>>> Signed-off-by: Nicolas Ferre >>>> can we detect it via the IP? >>> This was my first proposal, have it based on the value of MACB's >>> register 'MID' (offset 0x00fc, lower 16 bits). >>> On avr32 it reads: 0x0000010D, on Zynq it reports 0x00000119 >>> >>> So for the moment, CAPS_ISR_CLEAR_ON_WRITE could be set if the revision >>> equals to 0x00000119? >> so no it will not work >> >> as the gem on sama5 is 00020119 >> >> so version 0x119 too >> >> nico > > All right, that's a pity. > > The only issue that remains then is the obligation to use CONFIG_OF, > or: > > +#if defined(CONFIG_OF) > + dev_id = of_match_device(macb_dt_ids, &pdev->dev); > + if (dev_id) > + bp->caps = (u32)dev_id->data; > + > +#endif > > ? no need as of_match_device is a inline of !OF Best Regards, J. > > Hein > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/