Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932075Ab3ENIXU (ORCPT ); Tue, 14 May 2013 04:23:20 -0400 Received: from mail-ie0-f169.google.com ([209.85.223.169]:40595 "EHLO mail-ie0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751914Ab3ENIXS (ORCPT ); Tue, 14 May 2013 04:23:18 -0400 MIME-Version: 1.0 In-Reply-To: <1368019749-19455-3-git-send-email-lee.jones@linaro.org> References: <1368019749-19455-1-git-send-email-lee.jones@linaro.org> <1368019749-19455-3-git-send-email-lee.jones@linaro.org> Date: Tue, 14 May 2013 10:23:17 +0200 Message-ID: Subject: Re: [PATCH 2/9] mfd: ab8500-core: Use the correct driver name when enabling gpio/pinctrl From: Linus Walleij To: Lee Jones Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Linus WALLEIJ , Srinidhi KASAGAR , Samuel Ortiz Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1709 Lines: 42 On Wed, May 8, 2013 at 3:29 PM, Lee Jones wrote: > When we're using Device Tree to enable GPIO drivers we're forced to be > OS agnostic, thus we are forbidden use names like pinctrl as they are > specific only to Linux. Oh that depends. I have hade lectures on pin control at the embedded systems conference and there I treat it as a neutral term referring to this kind of electronic constructions. However how something is established in OF ontology I don't know so you might be right there, but you're making it sound like Documentation/devicetree/bindings/pinctrl/ should not exist and all those bindings be moved to gpio or something if the assumption that "pin control" or the abbreviation pinctrl is a Linux-specific term. (Which is not my interpretation.) > However, when we are registering devices using > internal systems such as MFD or platform registration, we can use such > terminology. In this case we can and should use the platform device ID > mechanism to specify which device we wish to utilise by detailing > pinctrl-. > > Cc: Samuel Ortiz > Signed-off-by: Lee Jones The commit message should state what regression it is actually solving. Which is that when using a non-DT boot, the ABx500 pinctrl devices are not probed, right? Apart from the commit message: Acked-by: Linus Walleij On the patch as such. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/