Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756755Ab3ENIaV (ORCPT ); Tue, 14 May 2013 04:30:21 -0400 Received: from mail-ie0-f173.google.com ([209.85.223.173]:47115 "EHLO mail-ie0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756281Ab3ENIaT (ORCPT ); Tue, 14 May 2013 04:30:19 -0400 MIME-Version: 1.0 In-Reply-To: <1368019749-19455-7-git-send-email-lee.jones@linaro.org> References: <1368019749-19455-1-git-send-email-lee.jones@linaro.org> <1368019749-19455-7-git-send-email-lee.jones@linaro.org> Date: Tue, 14 May 2013 10:30:18 +0200 Message-ID: Subject: Re: [PATCH 6/9] ARM: ux500: Provide device enumeration number suffix for SMSC911x From: Linus Walleij To: Lee Jones Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Linus WALLEIJ , Srinidhi KASAGAR Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 959 Lines: 25 On Wed, May 8, 2013 at 3:29 PM, Lee Jones wrote: > First Ethernet device has a ".0" appended onto the device name. It > appears that we need this in order to obtain the correct clock. > > Signed-off-by: Lee Jones (...) > - OF_DEV_AUXDATA("smsc,lan9115", 0x50000000, "smsc911x", NULL), > + OF_DEV_AUXDATA("smsc,lan9115", 0x50000000, "smsc911x.0", NULL), I guess what you want to say in the commit message is that on a non-DT boot the ethernet will be named "smsc911x.0" and since the clocks are not converted to device tree these names need to be matched when providing the name from auxdata. Edited the commit message and applied! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/