Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757053Ab3ENIrF (ORCPT ); Tue, 14 May 2013 04:47:05 -0400 Received: from mail-ia0-f180.google.com ([209.85.210.180]:60161 "EHLO mail-ia0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757025Ab3ENIq7 (ORCPT ); Tue, 14 May 2013 04:46:59 -0400 MIME-Version: 1.0 In-Reply-To: <1368019749-19455-10-git-send-email-lee.jones@linaro.org> References: <1368019749-19455-1-git-send-email-lee.jones@linaro.org> <1368019749-19455-10-git-send-email-lee.jones@linaro.org> Date: Tue, 14 May 2013 10:46:58 +0200 Message-ID: Subject: Re: [PATCH 9/9] mfd: ab8500-core: Pass GPADC compatible string to MFD core From: Linus Walleij To: Lee Jones Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Linus WALLEIJ , Srinidhi KASAGAR , Samuel Ortiz Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1452 Lines: 35 On Wed, May 8, 2013 at 3:29 PM, Lee Jones wrote: > When booting with Device Tree enabled the MFD core uses each device's > compatible string to find and allocate its associated of_node pointer, > which in turn is passed to the driver via the platform_device struct. > Without it, the driver won't be able to interrogate the Device Tree or > locate suitable regulators and will most likely fail to probe. > > Cc: Samuel Ortiz > Signed-off-by: Lee Jones Can you explain what regression this is causing since the GPADC driver (drivers/mfd/ab8500-gpadc.c) does not support device tree probing and does not have an .of_match_table defined in it's driver struct? I mean, what could possibly match that compatible string? The .name field will take care of naming the device does it not? For non-emergency merging though: Acked-by: Linus Walleij Since it matches the example in Documentation/devicetree/bindings/mfd/ab8500.txt But for this to make sense the AB8500 ADC driver needs to be augmented for DT probing and preferrably also moved to drivers/adc and made to utilize that subsystem. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/