Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757083Ab3ENIsE (ORCPT ); Tue, 14 May 2013 04:48:04 -0400 Received: from mail-ee0-f45.google.com ([74.125.83.45]:62100 "EHLO mail-ee0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756786Ab3ENIsB (ORCPT ); Tue, 14 May 2013 04:48:01 -0400 Date: Tue, 14 May 2013 09:47:56 +0100 From: Lee Jones To: Linus Walleij Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Linus WALLEIJ , Srinidhi KASAGAR Subject: Re: [PATCH 8/9] pinctrl: abx500: Rejiggle platform data and DT initialisation Message-ID: <20130514084756.GE3297@gmail.com> References: <1368019749-19455-1-git-send-email-lee.jones@linaro.org> <1368019749-19455-9-git-send-email-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1642 Lines: 40 On Tue, 14 May 2013, Linus Walleij wrote: > On Wed, May 8, 2013 at 3:29 PM, Lee Jones wrote: > > > A pointer to GPIO platform data is always passed to the driver now, so > > there's little point in checking for 'pdata' and executing the DT case if > > it's not there. The difference between booting with DT and !DT is when > > booting with DT, plat_id is not populated. Thus, in the DT case we have > > to use a DT match table in order to find out which platform we're > > executing on. So, we're changing the semantics here to only use the > > match table if no plat_id is supplied though platform data. > > > > Signed-off-by: Lee Jones > > Is this really included in the [0/9] fire alarm wrapper statement > "Important ux500 fixups due for the v3.10 -rc:s"? > > It seems more like a random refactoring to me. > > The commit message fails to specify which regression this > is fixing, like if it's causing an oops or so. > > So I've tentatively applied it to the pinctrl devel branch for > v3.11 unless something comes up... Perhaps the commit message is a bit weak, but yes, it _needs_ to go into v3.10, or this driver will be _broken_ when we boot with DT. Please apply this to your -fixes branch. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/