Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757140Ab3ENI4r (ORCPT ); Tue, 14 May 2013 04:56:47 -0400 Received: from mail-ie0-f180.google.com ([209.85.223.180]:59894 "EHLO mail-ie0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756631Ab3ENI4p (ORCPT ); Tue, 14 May 2013 04:56:45 -0400 MIME-Version: 1.0 In-Reply-To: <1368517100-22243-1-git-send-email-adam.lee@canonical.com> References: <1368517100-22243-1-git-send-email-adam.lee@canonical.com> Date: Tue, 14 May 2013 10:56:44 +0200 Message-ID: Subject: Re: [PATCH] mmc: core: Add a capability for disabling mmc cards From: Linus Walleij To: Adam Lee Cc: "linux-kernel@vger.kernel.org" , Nicolas Pitre , Doug Anderson , Alim Akhtar , Sebastian Rasmussen Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1293 Lines: 35 On Tue, May 14, 2013 at 9:38 AM, Adam Lee wrote: > On some systems we need a way to disable MMC card support in a MMC/SD > card slot due to the legal concern. > > Add support in the core SD/MMC code to support this. > > Signed-off-by: Doug Anderson > Signed-off-by: Alim Akhtar > Signed-off-by: Adam Lee (...) > #define MMC_CAP2_NO_PRESCAN_POWERUP (1 << 14) /* Don't power up before scan */ > +#define MMC_CAP2_NO_MMC (1 << 15) /* Only SD supported, not MMC */ I would name that MMC_CAP2_DISABLE_MMC_BUT_NOT_SD because that is what it means. People wanting to set that capability for said legal reasons will not read the git log. So also encode what you just said in the comment for the CAP so it is crystal clear what this is for. I'm a bit ambivalent about what kind of benefits this provides to human users of the Linux kernel, while I do understand the benefit it provides for legal bodies... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/