Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757291Ab3ENLFl (ORCPT ); Tue, 14 May 2013 07:05:41 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:37530 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752227Ab3ENLFk (ORCPT ); Tue, 14 May 2013 07:05:40 -0400 MIME-Version: 1.0 In-Reply-To: <1368497347-9628-9-git-send-email-namhyung@kernel.org> References: <1368497347-9628-1-git-send-email-namhyung@kernel.org> <1368497347-9628-9-git-send-email-namhyung@kernel.org> Date: Tue, 14 May 2013 14:05:38 +0300 X-Google-Sender-Auth: gTXbFl6lbJLMV7x1pMBeIaqyNuU Message-ID: Subject: Re: [PATCH 8/9] perf report: Add report.percent-limit config variable From: Pekka Enberg To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Paul Mackerras , Ingo Molnar , Namhyung Kim , LKML , Jiri Olsa , David Ahern , Stephane Eranian , Andi Kleen Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1008 Lines: 26 On Tue, May 14, 2013 at 5:09 AM, Namhyung Kim wrote: > From: Namhyung Kim > > Now an user can set a default value of --percent-limit option into the > perfconfig file. > > $ cat ~/.perfconfig > [report] > percent-limit = 0.1 > > Cc: Andi Kleen > Cc: Pekka Enberg > Signed-off-by: Namhyung Kim I'm not totally convinced this is useful. The limit is about "what is significant" and that depends on what you are trying to measure. There's an (absolute) lower limit somewhere between 0.1 and 1.0 but I think we can just pick a reasonable default and let people use the command line switch if they want to override it. Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/