Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757158Ab3ENLJI (ORCPT ); Tue, 14 May 2013 07:09:08 -0400 Received: from mail-ia0-f182.google.com ([209.85.210.182]:41983 "EHLO mail-ia0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753803Ab3ENLJG (ORCPT ); Tue, 14 May 2013 07:09:06 -0400 MIME-Version: 1.0 In-Reply-To: <20130514094036.GI3297@gmail.com> References: <1368019749-19455-1-git-send-email-lee.jones@linaro.org> <1368019749-19455-9-git-send-email-lee.jones@linaro.org> <20130514084756.GE3297@gmail.com> <20130514094036.GI3297@gmail.com> Date: Tue, 14 May 2013 13:09:05 +0200 Message-ID: Subject: Re: [PATCH 8/9] pinctrl: abx500: Rejiggle platform data and DT initialisation From: Linus Walleij To: Lee Jones Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Linus WALLEIJ , Srinidhi KASAGAR Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 914 Lines: 23 On Tue, May 14, 2013 at 11:40 AM, Lee Jones wrote: >> I'm happy to apply it but what do I write in the commit message? > > Platform Data is invariably populated for this driver, even when > booting with Device Tree. Thus the Device Tree probing code encased > within the first check for Platform Data will never executed, causing > the driver to fail when DT is enabled. > > This patch fixes the aforementioned regression by rejigging the > probe() semantics to attempt to extract a platform ID from Device Tree > if one can not be sourced from platform data. Thanks! Copy/pasted into commit message and applied to fixes. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/