Message-ID: <5192512C.6080006@broadcom.com>
Date: Tue, 14 May 2013 07:58:52 -0700
From: "Christian Daudt" <csd@broadcom.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130404
 Thunderbird/17.0.5
MIME-Version: 1.0
To: "Maxime Ripard" <maxime.ripard@free-electrons.com>
cc: "Michal Simek" <michal.simek@xilinx.com>,
        "Linus Walleij" <linus.walleij@linaro.org>,
        "Jamie Iles" <jamie@jamieiles.com>,
        "Simon Horman" <horms@verge.net.au>,
        "Magnus Damm" <magnus.damm@gmail.com>,
        "Viresh Kumar" <viresh.kumar@linaro.org>,
        "David Brown" <davidb@codeaurora.org>,
        "Jason Cooper" <jason@lakedaemon.net>, "Andrew Lunn" <andrew@lunn.ch>,
        "Gregory Clement" <gregory.clement@free-electrons.com>,
        "Shawn Guo" <shawn.guo@linaro.org>, "Barry Song" <baohua.song@csr.com>,
        "Tony Prisk" <linux@prisktech.co.nz>,
        linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        "Arnd Bergmann" <arnd@arndb.de>, "Olof Johansson" <olof@lixom.net>
Subject: Re: [PATCH 06/14] ARM: bcm281xx: Remove init_irq declaration in
 machine description
References: <1368438253-28218-1-git-send-email-maxime.ripard@free-electrons.com>
 <1368438253-28218-7-git-send-email-maxime.ripard@free-electrons.com>
 <519147C6.6080004@broadcom.com> <5191F503.2070301@free-electrons.com>
In-Reply-To: <5191F503.2070301@free-electrons.com>
Content-Type: text/plain;
 charset=iso-8859-1;
 format=flowed
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1669
Lines: 46

On 13-05-14 01:25 AM, Maxime Ripard wrote:
> Hi Christian,
>
> Le 13/05/2013 22:06, Christian Daudt a ?crit :
>> On 13-05-13 02:44 AM, Maxime Ripard wrote:
>>> Commit ebafed7a ("ARM: irq: Call irqchip_init if no init_irq function is
>>> specified") removed the need to explictly setup the init_irq field in
>>> the machine description when using only irqchip_init. Remove that
>>> declaration for bcm281xx as well.
>>>
>>> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>>> ---
>>>    arch/arm/mach-bcm/board_bcm.c | 1 -
>>>    1 file changed, 1 deletion(-)
>>>
>>> diff --git a/arch/arm/mach-bcm/board_bcm.c
>>> b/arch/arm/mach-bcm/board_bcm.c
>>> index 22e8421..24556cf 100644
>>> --- a/arch/arm/mach-bcm/board_bcm.c
>>> +++ b/arch/arm/mach-bcm/board_bcm.c
>>> @@ -54,7 +54,6 @@ static void __init board_init(void)
>>>    static const char * const bcm11351_dt_compat[] = { "bcm,bcm11351",
>>> NULL, };
>>>      DT_MACHINE_START(BCM11351_DT, "Broadcom Application Processor")
>>> -    .init_irq = irqchip_init,
>>>        .init_time = clocksource_of_init,
>>>        .init_machine = board_init,
>>>        .dt_compat = bcm11351_dt_compat,
>> Acked-by: Christian Daudt <csd@broadcom.com>
> Thanks!
>
> I forgot to remove the include of irqchip.h into all these patches, so
> I'll send a v2, and I guess you could probably merge it through your
> tree after that directly.
Ok. will do.

  thanks,
    csd


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/