Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756917Ab3ENRqC (ORCPT ); Tue, 14 May 2013 13:46:02 -0400 Received: from mail-la0-f54.google.com ([209.85.215.54]:58501 "EHLO mail-la0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753398Ab3ENRqA (ORCPT ); Tue, 14 May 2013 13:46:00 -0400 MIME-Version: 1.0 In-Reply-To: <1368542918-8861-5-git-send-email-imre.deak@intel.com> References: <1368188011-23661-1-git-send-email-imre.deak@intel.com> <1368542918-8861-1-git-send-email-imre.deak@intel.com> <1368542918-8861-5-git-send-email-imre.deak@intel.com> Date: Tue, 14 May 2013 13:45:58 -0400 Message-ID: Subject: Re: [PATCH v2 4/8] media/si4713-i2c: take usecs_to_jiffies_timeout into use From: "edubezval@gmail.com" To: Imre Deak Cc: linux-kernel@vger.kernel.org, Andrew Morton , Daniel Vetter , Mauro Carvalho Chehab , Hans Verkuil , Peter Senna Tschudin , linux-media@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1834 Lines: 48 Imre, On Tue, May 14, 2013 at 10:48 AM, Imre Deak wrote: > Use usecs_to_jiffies_timeout instead of open-coding the same. > > Signed-off-by: Imre Deak Acked-by: Eduardo Valentin > --- > drivers/media/radio/si4713-i2c.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/radio/si4713-i2c.c b/drivers/media/radio/si4713-i2c.c > index fe16088..e12f058 100644 > --- a/drivers/media/radio/si4713-i2c.c > +++ b/drivers/media/radio/si4713-i2c.c > @@ -233,7 +233,7 @@ static int si4713_send_command(struct si4713_device *sdev, const u8 command, > > /* Wait response from interrupt */ > if (!wait_for_completion_timeout(&sdev->work, > - usecs_to_jiffies(usecs) + 1)) > + usecs_to_jiffies_timeout(usecs))) > v4l2_warn(&sdev->sd, > "(%s) Device took too much time to answer.\n", > __func__); > @@ -470,7 +470,7 @@ static int si4713_wait_stc(struct si4713_device *sdev, const int usecs) > > /* Wait response from STC interrupt */ > if (!wait_for_completion_timeout(&sdev->work, > - usecs_to_jiffies(usecs) + 1)) > + usecs_to_jiffies_timeout(usecs))) > v4l2_warn(&sdev->sd, > "%s: device took too much time to answer (%d usec).\n", > __func__, usecs); > -- > 1.7.10.4 > -- Eduardo Bezerra Valentin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/