Message-id: <1368592699.11843.10.camel@kjgkr>
Subject: Re: [PATCH 1/2] f2fs: fix inconsistency of block count during recovery
From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Reply-to: jaegeuk.kim@samsung.com
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net
Date: Wed, 15 May 2013 13:38:19 +0900
In-reply-to: <CAKYAXd8r7EcbrPuHJcz9Ft=ienP6gT84QBP8VWUDeKm=v=mcfA@mail.gmail.com>
References: <1368575992-7142-1-git-send-email-jaegeuk.kim@samsung.com>
 <CAKYAXd8r7EcbrPuHJcz9Ft=ienP6gT84QBP8VWUDeKm=v=mcfA@mail.gmail.com>
Organization: samsung
Content-type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="=-FyiqWqBY2dpX7RQvBvNp"
MIME-version: 1.0
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2540
Lines: 80


--=-FyiqWqBY2dpX7RQvBvNp
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

2013-05-15 (=EC=88=98), 12:47 +0900, Namjae Jeon:
> >
> > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
> > index 3df43b4..9641534 100644
> > --- a/fs/f2fs/node.c
> > +++ b/fs/f2fs/node.c
> > @@ -1492,6 +1492,8 @@ int recover_inode_page(struct f2fs_sb_info *sbi,
> > struct page *page)
> >  	new_ni =3D old_ni;
> >  	new_ni.ino =3D ino;
> >
> Hi. Jaegeuk.
>=20
> I have a minor comment.
> > +	if (!inc_valid_node_count(sbi, NULL, 1))
> > +		WARN_ON(1);

Hi Namjae,

Negative since inc_valid_node_count() is not for debugging.
IMO, for readability, we need to make clear what the function call is
used for.
Thank you for the review. :)

> How about change WARN_ON(!inc_valid_node_count(sbi, NULL, 1)); ?
>=20
> Reviewed-by: Namjae Jeon <namjae.jeon@samsung.com>
> Thanks.
> >  	set_node_addr(sbi, &new_ni, NEW_ADDR);
> >  	inc_valid_inode_count(sbi);
> >
> > --
> > 1.8.1.3.566.gaa39828
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel=
" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >

--=20
Jaegeuk Kim
Samsung

--=-FyiqWqBY2dpX7RQvBvNp
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAABAgAGBQJRkxE7AAoJEEAUqH6CSFDSnbUP/2KBdvVlyPZfJuuKS2n7LGVq
Dc6ej1Q4qEjn//q3boEzl9aCpkN0MoRryzxzgg1jk0bynk4jOHU8GZg80axpXTsl
vB0yTTwWfrDuQB2v/ruIxnBJaaOIWRM76bdirMPT99g2t0ePModvtWLCkJS/4jZI
+7gjlB3ZS/PpgAwpPAyqHExRhqmH7sWonmzLPFcUdD0ChKov/jXYdNcdJ7LZhRyd
hVfWOqGI5dtD2vHOD9CjRo8Tc5waDOALF0N0ZNquJQIbXrMNezHsDkf2lhleQuW9
YZp3INHBNveE9LChZpdfQdNuvMsUcwF6u/zCynOSpDQH3+1GIYJtwtsnuPO+i3bw
Lg1FB7shzCsaB9cH5S06yIS8TRbud+9lptC9JJnPp64NRbi3p7S7XA9+uWEOc06Z
LkRYUHKjKSyU3XfwCFCbAP5VraedKDnIvBUn2sMwNsk8aaaqzCR5BIcqh2FdC128
dswjYLOFcXvfK8i7QtOC2Moe/Mb548IpMyjOwNHrF61TEaKwCbYcwygWrGA+5Bvb
vHp2MIiEM0dAw0zfkkN9j3IvMjPIxoWJkbMg4dXVoRCpe7ZT2BuCUeLtjW72cBnW
/7U57K5xElqbijdFpdGJB9q031wZ7od+GjVwz4mV6KBmuVQY7MKYEwnC6mEfQ/9v
+V/r91bwrIDAS86mvqWg
=4YMo
-----END PGP SIGNATURE-----

--=-FyiqWqBY2dpX7RQvBvNp--

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/