Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Sun, 29 Sep 2002 16:08:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Sun, 29 Sep 2002 16:08:24 -0400 Received: from serenity.mcc.ac.uk ([130.88.200.93]:21259 "EHLO serenity.mcc.ac.uk") by vger.kernel.org with ESMTP id ; Sun, 29 Sep 2002 16:08:23 -0400 Date: Sun, 29 Sep 2002 21:13:32 +0100 From: John Levon To: Tim Schmielau Cc: Arnaldo Carvalho de Melo , lkml Subject: Re: [PATCH] break out task_struct from sched.h Message-ID: <20020929201331.GA90617@compsoc.man.ac.uk> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.25i X-Url: http://www.movementarian.org/ X-Record: Mr. Scruff - Trouser Jazz Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 906 Lines: 23 On Sun, Sep 29, 2002 at 09:50:48PM +0200, Tim Schmielau wrote: > This patch separates struct task_struct from to > a new header , so that dereferencing 'current' > doesn't require to #include and all of the 138 files it > drags in. It seems a bit odd to me that you /only/ split out task_struct but none of the simple helpers (for_each_process(), task_lock, set_task_state etc.). I'd prefer a task.h personally, many of these can be placed without further burdening the include nest. It'd certainly be nice to see sched.h properly cleaned up at some point (request_irq() ??? d_path() ???) regards john - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/