Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754160Ab3EOFVE (ORCPT ); Wed, 15 May 2013 01:21:04 -0400 Received: from ozlabs.org ([203.10.76.45]:33336 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751512Ab3EOFU7 (ORCPT ); Wed, 15 May 2013 01:20:59 -0400 From: Rusty Russell To: Asias He , "Michael S. Tsirkin" Cc: Nicholas Bellinger , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, target-devel@vger.kernel.org, Asias He , Stephen Rothwell , Randy Dunlap , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Subject: Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec In-Reply-To: <1368579583-13097-1-git-send-email-asias@redhat.com> References: <20130515095558.918f2b29ba318a477eb5dde2@canb.auug.org.au> <1368579583-13097-1-git-send-email-asias@redhat.com> User-Agent: Notmuch/0.15.2+81~gd2c8818 (http://notmuchmail.org) Emacs/23.4.1 (i686-pc-linux-gnu) Date: Wed, 15 May 2013 14:47:53 +0930 Message-ID: <8761yk254u.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 791 Lines: 27 Asias He writes: > scsi.c includes vhost.c which uses memcpy_fromiovec. > > This patch fixes this build failure. > > From Randy Dunlap: > ''' > on x86_64: > > ERROR: "memcpy_fromiovec" [drivers/vhost/vhost_scsi.ko] undefined! > > It needs to depend on NET since net/core/ provides that function. > ''' Proper fix please. Though I can't see why you thought this was a good idea. Nonetheless, I shan't highlight why: I have far too much respect for your intellects and abilities. No, don't thank me! Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/