Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758812Ab3EOJl4 (ORCPT ); Wed, 15 May 2013 05:41:56 -0400 Received: from perceval.ideasonboard.com ([95.142.166.194]:39742 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758785Ab3EOJlx (ORCPT ); Wed, 15 May 2013 05:41:53 -0400 From: Laurent Pinchart To: Prabhakar Lad Cc: LMML , LKML , DLOS , Hans Verkuil , Mauro Carvalho Chehab , Guennadi Liakhovetski , Sylwester Nawrocki , Sakari Ailus , Grant Likely , Rob Herring , Rob Landley , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org Subject: Re: [PATCH 5/5] media: i2c: tvp7002: add OF support Date: Wed, 15 May 2013 11:42:11 +0200 Message-ID: <4739069.jGxFT2O6sk@avalon> User-Agent: KMail/4.10.2 (Linux/3.7.10-gentoo-r1; KDE/4.10.2; x86_64; ; ) In-Reply-To: References: <1368528334-13595-1-git-send-email-prabhakar.csengg@gmail.com> <4149647.zqpmlIlQDP@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3047 Lines: 80 Hi Prabhakar, On Wednesday 15 May 2013 10:48:05 Prabhakar Lad wrote: > On Tue, May 14, 2013 at 9:04 PM, Laurent Pinchart wrote: > > On Tuesday 14 May 2013 16:15:34 Lad Prabhakar wrote: > >> From: Lad, Prabhakar > >> > >> add OF support for the tvp7002 driver. > >> > >> Signed-off-by: Lad, Prabhakar > >> Cc: Hans Verkuil > >> Cc: Laurent Pinchart > >> Cc: Mauro Carvalho Chehab > >> Cc: Guennadi Liakhovetski > >> Cc: Sylwester Nawrocki > >> Cc: Sakari Ailus > >> Cc: Grant Likely > >> Cc: Rob Herring > >> Cc: Rob Landley > >> Cc: devicetree-discuss@lists.ozlabs.org > >> Cc: linux-doc@vger.kernel.org > >> Cc: linux-kernel@vger.kernel.org > >> Cc: davinci-linux-open-source@linux.davincidsp.com > >> --- > >> > >> .../devicetree/bindings/media/i2c/tvp7002.txt | 42 +++++++++++++ > >> drivers/media/i2c/tvp7002.c | 64 ++++++++++++-- > >> 2 files changed, 99 insertions(+), 7 deletions(-) > >> create mode 100644 > >> Documentation/devicetree/bindings/media/i2c/tvp7002.txt > >> > >> diff --git a/Documentation/devicetree/bindings/media/i2c/tvp7002.txt > >> b/Documentation/devicetree/bindings/media/i2c/tvp7002.txt new file mode > >> 100644 > >> index 0000000..1ebd8b1 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/media/i2c/tvp7002.txt > >> @@ -0,0 +1,42 @@ > >> +* Texas Instruments TV7002 video decoder > >> + > >> +The TVP7002 device supports digitizing of video and graphics signal in > >> +RGB and +YPbPr color space. > >> + > >> +Required Properties : > >> +- compatible : Must be "ti,tvp7002" > >> + > >> +- hsync-active: HSYNC Polarity configuration for endpoint. > >> + > >> +- vsync-active: VSYNC Polarity configuration for endpoint. > >> + > >> +- pclk-sample: Clock polarity of the endpoint. > >> + > >> +- ti,tvp7002-fid-polarity: Active-high Field ID polarity of the > >> endpoint. > >> + > >> +- ti,tvp7002-sog-polarity: Sync on Green output polarity of the > >> endpoint. > > > > Would it make sense to define field-active and sog-active properties in > > the V4L2 bindings instead of having per-chip properties ? > > yes you are right these properties need to be in the device node rather than > the port node. I'll send alone this patch of the series as v2 fixing the > above. That wasn't my point. What I'm wondering is whether ti,tvp7002-fid-polarity shouldn't be named field-active and specified in Documentation/devicetree/bindings/media/video-interfaces.txt (same for ti,tvp7002-sog-polarity). -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/