Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932601Ab3EOKDi (ORCPT ); Wed, 15 May 2013 06:03:38 -0400 Received: from mga14.intel.com ([143.182.124.37]:9730 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932401Ab3EOKDf (ORCPT ); Wed, 15 May 2013 06:03:35 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,675,1363158000"; d="scan'208";a="302742469" Message-ID: <1368612357.15764.26.camel@sauron.fi.intel.com> Subject: Re: [PATCH v5 00/11] mtd: add datasheet's ECC information to nand_chip{} From: Artem Bityutskiy Reply-To: dedekind1@gmail.com To: Huang Shijie , "computersforpeace@gmail.com" Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Date: Wed, 15 May 2013 13:05:57 +0300 In-Reply-To: <1368607232-2210-1-git-send-email-b32955@freescale.com> References: <1368607232-2210-1-git-send-email-b32955@freescale.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4 (3.6.4-3.fc18) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1278 Lines: 27 On Wed, 2013-05-15 at 16:40 +0800, Huang Shijie wrote: > 1.) Why add the ECC information to the nand_chip{} ? > Each nand chip has its requirement for the ECC correctability, such as > "4bit ECC for each 512Byte" or "40bit ECC for each 1024Byte". > This ECC info is very important to the nand controller, such as gpmi. > > Take the Micron MT29F64G08CBABA for example, its geometry is > 8k page size, 744 bytes oob size and it requires 40bit ECC per 1K bytes. > If we do not provide the ECC info to the gpmi nand driver, it has to > calculate the ECC correctability itself. The gpmi driver will gets the 56bit > ECC for per 1K bytes which is beyond its BCH's 40bit ecc capibility. > The gpmi will quits in this case. But in actually, the gpmi can supports > this nand chip if it can get the right ECC info. Thanks. Brian has disappeared, may be busy, but I would still like to wait for his response. At the very least, I would like to make sure he does not object. -- Best Regards, Artem Bityutskiy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/