Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757978Ab3EOLSG (ORCPT ); Wed, 15 May 2013 07:18:06 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:40633 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755975Ab3EOLSE (ORCPT ); Wed, 15 May 2013 07:18:04 -0400 Message-ID: <1368616680.19370.4.camel@dabdike> Subject: Re: [PATCH 1/2] Kernel/time: Introduce a new timestamp function local_time_seconds() From: James Bottomley To: Gu Zheng Cc: John Stultz , Andrew Morton , linux-kernel , linux-scsi@vger.kernel.org Date: Wed, 15 May 2013 07:18:00 -0400 In-Reply-To: <519301D8.2030502@cn.fujitsu.com> References: <5191EBA7.9010303@cn.fujitsu.com> <51925EDC.2080307@linaro.org> <519301D8.2030502@cn.fujitsu.com> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.8.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1348 Lines: 33 On Wed, 2013-05-15 at 11:32 +0800, Gu Zheng wrote: > On 05/14/2013 11:57 PM, John Stultz wrote: > > > On 05/14/2013 12:45 AM, Gu Zheng wrote: > >> From 18072c1c3506a7e37ee485307a2c343efe5af4d0 Mon Sep 17 00:00:00 2001 > >> From: Gu Zheng > >> Date: Mon, 13 May 2013 15:45:24 +0900 > >> Subject: [PATCH 1/2] Kernel/time: Introduce a new timestamp function local_time_seconds() > >> > >> Introduce a new timestamp function local_time_seconds() to hide the conversion of system time in UTC to local time seconds. > > > > So, why is this useful/needed? > > Hi John, > There are some subsystems use local time seconds as a timestamp, > such as scsi(refer > to:http://www.spinics.net/lists/linux-scsi/msg66089.html), > and so do many out-of-kernel-tree code I think. I don't think the 3ware drivers, which are the only ones that do this actually care. I think jiffies to seconds would suit the event timestamps equally well, so I don't really see a need to make this a formal kernel export given that it's only a single driver family in the entirety of the kernel. James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/