Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Sun, 29 Sep 2002 17:01:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Sun, 29 Sep 2002 17:01:44 -0400 Received: from svr-ganmtc-appserv-mgmt.ncf.coxexpress.com ([24.136.46.5]:37391 "EHLO svr-ganmtc-appserv-mgmt.ncf.coxexpress.com") by vger.kernel.org with ESMTP id ; Sun, 29 Sep 2002 17:01:44 -0400 Subject: Re: [PATCH] break out task_struct from sched.h From: Robert Love To: Tim Schmielau Cc: John Levon , Arnaldo Carvalho de Melo , lkml In-Reply-To: References: Content-Type: text/plain Organization: Message-Id: <1033333589.22056.1381.camel@phantasy> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.1.1.99 (Preview Release) Date: 29 Sep 2002 17:06:29 -0400 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1101 Lines: 30 On Sun, 2002-09-29 at 17:00, Tim Schmielau wrote: > You're right. > I had the vague hope that by separating type definitions only > some future cleanup might help us to cut down on the number of > headers included by task_struct.h (currently 60). > Introducing a full-blown task.h looks like killing sched.h completely I like this: introduce a tasks.h to separate the task_struct and any helper macros that depend on it. We can keep sched.h though - but just for scheduler stuff from sched.c. We need a place to put the prototypes, inlines, and defines from sched.c and sched.h is the cleanest place. It is the other stuff (task_struct most importantly, as you point out) that needs to go. > Killing ~600 #include lines however seemed enough for a > first round, so I left this for later iterations. Indeed, good job. Robert Love - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/