Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932655Ab3EONYH (ORCPT ); Wed, 15 May 2013 09:24:07 -0400 Received: from perceval.ideasonboard.com ([95.142.166.194]:40986 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754581Ab3EONYE (ORCPT ); Wed, 15 May 2013 09:24:04 -0400 From: Laurent Pinchart To: Lad Prabhakar Cc: LMML , LKML , DLOS , Hans Verkuil , Mauro Carvalho Chehab , Guennadi Liakhovetski , Sylwester Nawrocki , Sakari Ailus , Grant Likely , Rob Herring , Rob Landley , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, Kyungmin Park Subject: Re: [PATCH RFC] media: OF: add field-active and sync-on-green endpoint properties Date: Wed, 15 May 2013 15:24:23 +0200 Message-ID: <2510029.UKsn4JyZOW@avalon> User-Agent: KMail/4.10.2 (Linux/3.7.10-gentoo-r1; KDE/4.10.2; x86_64; ; ) In-Reply-To: <1368622349-32185-1-git-send-email-prabhakar.csengg@gmail.com> References: <1368622349-32185-1-git-send-email-prabhakar.csengg@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3511 Lines: 92 Hi Prabhakar, Thank you for the patch. On Wednesday 15 May 2013 18:22:29 Lad Prabhakar wrote: > From: Lad, Prabhakar > > This patch adds "field-active" and "sync-on-green" as part of > endpoint properties and also support to parse them in the parser. > > Signed-off-by: Lad, Prabhakar > Cc: Hans Verkuil > Cc: Laurent Pinchart > Cc: Mauro Carvalho Chehab > Cc: Guennadi Liakhovetski > Cc: Sylwester Nawrocki > Cc: Sakari Ailus > Cc: Grant Likely > Cc: Rob Herring > Cc: Rob Landley > Cc: devicetree-discuss@lists.ozlabs.org > Cc: linux-doc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: davinci-linux-open-source@linux.davincidsp.com > Cc: Kyungmin Park > --- > .../devicetree/bindings/media/video-interfaces.txt | 4 ++++ > drivers/media/v4l2-core/v4l2-of.c | 6 ++++++ > include/media/v4l2-mediabus.h | 2 ++ > 3 files changed, 12 insertions(+), 0 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt > b/Documentation/devicetree/bindings/media/video-interfaces.txt index > e022d2d..6bf87d0 100644 > --- a/Documentation/devicetree/bindings/media/video-interfaces.txt > +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt > @@ -101,6 +101,10 @@ Optional endpoint properties > array contains only one entry. > - clock-noncontinuous: a boolean property to allow MIPI CSI-2 > non-continuous clock mode. > +-field-active: a boolean property indicating active high filed ID output > + polarity is inverted. Looks like we already have field-even-active property to describe the level of the field signal. Could you please check whether it fulfills your use cases ? Sorry for not pointing you to it earlier. > +-sync-on-green: a boolean property indicating to sync with the green signal > in + RGB. > > > Example > diff --git a/drivers/media/v4l2-core/v4l2-of.c > b/drivers/media/v4l2-core/v4l2-of.c index aa59639..1d59455 100644 > --- a/drivers/media/v4l2-core/v4l2-of.c > +++ b/drivers/media/v4l2-core/v4l2-of.c > @@ -100,6 +100,12 @@ static void v4l2_of_parse_parallel_bus(const struct > device_node *node, if (!of_property_read_u32(node, "data-shift", &v)) > bus->data_shift = v; > > + if (of_get_property(node, "field-active", &v)) > + flags |= V4L2_MBUS_FIELD_ACTIVE; > + > + if (of_get_property(node, "sync-on-green", &v)) > + flags |= V4L2_MBUS_SOG; > + > bus->flags = flags; > > } > diff --git a/include/media/v4l2-mediabus.h b/include/media/v4l2-mediabus.h > index 83ae07e..b95553d 100644 > --- a/include/media/v4l2-mediabus.h > +++ b/include/media/v4l2-mediabus.h > @@ -40,6 +40,8 @@ > #define V4L2_MBUS_FIELD_EVEN_HIGH (1 << 10) > /* FIELD = 1/0 - Field1 (odd)/Field2 (even) */ > #define V4L2_MBUS_FIELD_EVEN_LOW (1 << 11) > +#define V4L2_MBUS_FIELD_ACTIVE (1 << 12) > +#define V4L2_MBUS_SOG (1 << 13) > > /* Serial flags */ > /* How many lanes the client can use */ -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/