Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757175Ab3EOUJz (ORCPT ); Wed, 15 May 2013 16:09:55 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:36127 "EHLO e7.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753986Ab3EOUJx (ORCPT ); Wed, 15 May 2013 16:09:53 -0400 Date: Wed, 15 May 2013 15:09:42 -0500 From: Seth Jennings To: Konrad Rzeszutek Wilk Cc: Dan Magenheimer , Andrew Morton , Greg Kroah-Hartman , Nitin Gupta , Minchan Kim , Robert Jennings , Jenifer Hopper , Mel Gorman , Johannes Weiner , Rik van Riel , Larry Woodman , Benjamin Herrenschmidt , Dave Hansen , Joe Perches , Joonsoo Kim , Cody P Schafer , Hugh Dickens , Paul Mackerras , linux-mm@kvack.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCHv11 3/4] zswap: add to mm/ Message-ID: <20130515200942.GA17724@cerebellum> References: <1368448803-2089-1-git-send-email-sjenning@linux.vnet.ibm.com> <1368448803-2089-4-git-send-email-sjenning@linux.vnet.ibm.com> <15c5b1da-132a-4c9e-9f24-bc272d3865d5@default> <20130514163541.GC4024@medulla> <20130514225501.GA11956@cerebellum> <4d74f5db-11c1-4f58-97f4-8d96bbe601ac@default> <20130515185506.GA23342@phenom.dumpdata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130515185506.GA23342@phenom.dumpdata.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13051520-5806-0000-0000-0000212C2B6D Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1221 Lines: 34 On Wed, May 15, 2013 at 02:55:06PM -0400, Konrad Rzeszutek Wilk wrote: > > Sorry, but I don't think that's appropriate for a patch in the MM subsystem. > > I am heading to the airport shortly so this email is a bit hastily typed. > > Perhaps a compromise can be reached where this code is merged as a driver > not a core mm component. There is a high bar to be in the MM - it has to > work with many many different configurations. > > And drivers don't have such a high bar. They just need to work on a specific > issue and that is it. If zswap ended up in say, drivers/mm that would make > it more palpable I think. > > Thoughts? zswap, the writeback code particularly, depends on a number of non-exported kernel symbols, namely: swapcache_free __swap_writepage __add_to_swap_cache swapcache_prepare swapper_spaces So it can't currently be built as a module and I'm not sure what the MM folks would think about exporting them and making them part of the KABI. Seth -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/