Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933097Ab3EOUrK (ORCPT ); Wed, 15 May 2013 16:47:10 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:46253 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932193Ab3EOUrJ convert rfc822-to-8bit (ORCPT ); Wed, 15 May 2013 16:47:09 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <20130515200942.GA17724@cerebellum> References: <1368448803-2089-1-git-send-email-sjenning@linux.vnet.ibm.com> <1368448803-2089-4-git-send-email-sjenning@linux.vnet.ibm.com> <15c5b1da-132a-4c9e-9f24-bc272d3865d5@default> <20130514163541.GC4024@medulla> <20130514225501.GA11956@cerebellum> <4d74f5db-11c1-4f58-97f4-8d96bbe601ac@default> <20130515185506.GA23342@phenom.dumpdata.com> <20130515200942.GA17724@cerebellum> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCHv11 3/4] zswap: add to mm/ From: Konrad Rzeszutek Wilk Date: Wed, 15 May 2013 16:45:36 -0400 To: Seth Jennings CC: Dan Magenheimer , Andrew Morton , Greg Kroah-Hartman , Nitin Gupta , Minchan Kim , Robert Jennings , Jenifer Hopper , Mel Gorman , Johannes Weiner , Rik van Riel , Larry Woodman , Benjamin Herrenschmidt , Dave Hansen , Joe Perches , Joonsoo Kim , Cody P Schafer , Hugh Dickens , Paul Mackerras , linux-mm@kvack.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Message-ID: X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1461 Lines: 47 Seth Jennings wrote: >On Wed, May 15, 2013 at 02:55:06PM -0400, Konrad Rzeszutek Wilk wrote: >> > Sorry, but I don't think that's appropriate for a patch in the MM >subsystem. >> >> I am heading to the airport shortly so this email is a bit hastily >typed. >> >> Perhaps a compromise can be reached where this code is merged as a >driver >> not a core mm component. There is a high bar to be in the MM - it has >to >> work with many many different configurations. >> >> And drivers don't have such a high bar. They just need to work on a >specific >> issue and that is it. If zswap ended up in say, drivers/mm that would >make >> it more palpable I think. >> >> Thoughts? > >zswap, the writeback code particularly, depends on a number of >non-exported >kernel symbols, namely: > >swapcache_free >__swap_writepage >__add_to_swap_cache >swapcache_prepare >swapper_spaces > >So it can't currently be built as a module and I'm not sure what the MM >folks would think about exporting them and making them part of the >KABI. > >Seth Could those calls go through front swap? Meaning put the code that uses these calls in there? -- Sent from my Android phone. Please excuse my brevity. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/