Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753680Ab3EOViO (ORCPT ); Wed, 15 May 2013 17:38:14 -0400 Received: from mail-ob0-f182.google.com ([209.85.214.182]:49824 "EHLO mail-ob0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751414Ab3EOViN (ORCPT ); Wed, 15 May 2013 17:38:13 -0400 MIME-Version: 1.0 In-Reply-To: <20130515090602.28109.90142.stgit@localhost6.localdomain6> References: <20130515090507.28109.28956.stgit@localhost6.localdomain6> <20130515090602.28109.90142.stgit@localhost6.localdomain6> From: KOSAKI Motohiro Date: Wed, 15 May 2013 17:37:52 -0400 X-Google-Sender-Auth: 555GY35LmVM2_S7ayCkh7ue6nXk Message-ID: Subject: Re: [PATCH v6 4/8] vmalloc: make find_vm_area check in range To: HATAYAMA Daisuke Cc: vgoyal@redhat.com, "Eric W. Biederman" , Andrew Morton , cpw@sgi.com, kumagai-atsushi@mxc.nes.nec.co.jp, lisa.mitchell@hp.com, kexec@lists.infradead.org, LKML , zhangyanfei@cn.fujitsu.com, jingbai.ma@hp.com, "linux-mm@kvack.org" , "riel@redhat.com" , Michel Lespinasse , Hugh Dickins Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1609 Lines: 39 On Wed, May 15, 2013 at 5:06 AM, HATAYAMA Daisuke wrote: > Currently, __find_vmap_area searches for the kernel VM area starting > at a given address. This patch changes this behavior so that it > searches for the kernel VM area to which the address belongs. This > change is needed by remap_vmalloc_range_partial to be introduced in > later patch that receives any position of kernel VM area as target > address. > > This patch changes the condition (addr > va->va_start) to the > equivalent (addr >= va->va_end) by taking advantage of the fact that > each kernel VM area is non-overlapping. > > Signed-off-by: HATAYAMA Daisuke > --- > > mm/vmalloc.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index d365724..3875fa2 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -292,7 +292,7 @@ static struct vmap_area *__find_vmap_area(unsigned long addr) > va = rb_entry(n, struct vmap_area, rb_node); > if (addr < va->va_start) > n = n->rb_left; > - else if (addr > va->va_start) > + else if (addr >= va->va_end) > n = n->rb_right; OK. This is natural definition. Looks good. Acked-by: KOSAKI Motohiro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/