Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754985Ab3EPDzL (ORCPT ); Wed, 15 May 2013 23:55:11 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:45253 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753781Ab3EPDzI (ORCPT ); Wed, 15 May 2013 23:55:08 -0400 Message-ID: <1368676505.2194.47.camel@joe-AO722> Subject: Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec From: Joe Perches To: Rusty Russell Cc: Asias He , "Michael S. Tsirkin" , Nicholas Bellinger , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, target-devel@vger.kernel.org, Stephen Rothwell , Randy Dunlap , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Date: Wed, 15 May 2013 20:55:05 -0700 In-Reply-To: <87d2sra97h.fsf@rustcorp.com.au> References: <20130515095558.918f2b29ba318a477eb5dde2@canb.auug.org.au> <1368579583-13097-1-git-send-email-asias@redhat.com> <8761yk254u.fsf@rustcorp.com.au> <20130516020848.GB23441@hj.localdomain> <87d2sra97h.fsf@rustcorp.com.au> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1535 Lines: 30 On Thu, 2013-05-16 at 13:04 +0930, Rusty Russell wrote: > Asias He writes: > > On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote: [] > > Other users are using memcpy_fromiovec and friends outside net. It seems > > a good idea to put it in a util library. e.g. crypto/algif_skcipher.c > > which also depends on NET for it. [] > Subject: Hoist memcpy_fromiovec into lib/ You'll need the "friends" memcpy_toiovec too. $ git grep -E \bmemcpy\w+iovec\w*" crypto/algif_hash.c: err = memcpy_toiovec(msg->msg_iov, ctx->result, len); crypto/algif_skcipher.c: err = memcpy_fromiovec(page_address(sg_page(sg)) + crypto/algif_skcipher.c: err = memcpy_fromiovec(page_address(sg_page(sg + i)), drivers/dma/iovlock.c:#include /* for memcpy_toiovec */ drivers/dma/iovlock.c: return memcpy_toiovec(iov, kdata, len); drivers/dma/iovlock.c: err = memcpy_toiovec(iov, vaddr + offset, len); drivers/isdn/mISDN/socket.c: if (memcpy_fromiovec(skb_put(skb, len), msg->msg_iov, len)) { drivers/misc/vmw_vmci/vmci_queue_pair.c: err = memcpy_fromiovec((u8 *)va + page_o drivers/misc/vmw_vmci/vmci_queue_pair.c: err = memcpy_toiovec(iov, (u8 *)va + pag -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/