Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755966Ab3EPHxe (ORCPT ); Thu, 16 May 2013 03:53:34 -0400 Received: from mx03.lb01.inode.at ([62.99.145.3]:26962 "EHLO mx.inode.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754989Ab3EPHxd (ORCPT ); Thu, 16 May 2013 03:53:33 -0400 Message-ID: <51949076.9040008@streamunlimited.com> Date: Thu, 16 May 2013 09:53:26 +0200 From: Marek Belisko User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Mike Turquette CC: Marek Belisko , zonque@gmail.com, vladimir.koutny@streamunlimited.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] clk: si5351: Fix clkout rate computation. References: <1367560403-21685-1-git-send-email-marek.belisko@streamunlimited.com> <20130514191650.10068.92925@quantum> In-Reply-To: <20130514191650.10068.92925@quantum> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: marek.belisko@streamunlimited.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1766 Lines: 60 On 05/14/2013 09:16 PM, Mike Turquette wrote: > Quoting Marek Belisko (2013-05-02 22:53:22) >> Rate was incorrectly computed because we read from wrong divider register. >> >> Signed-off-by: Marek Belisko >> Acked-by: Sebastian Hesselbarth > > Do either of these patches need to go into clk-fixes? If so please be > explicit about it in the changelog, the section under the three dashes. Yes I believe they should go to clk-fixes (probably also to linux-stable). > > Regards, > Mike > >> --- >> drivers/clk/clk-si5351.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c >> index 8927284..cf39e53 100644 >> --- a/drivers/clk/clk-si5351.c >> +++ b/drivers/clk/clk-si5351.c >> @@ -932,7 +932,7 @@ static unsigned long si5351_clkout_recalc_rate(struct clk_hw *hw, >> unsigned char reg; >> unsigned char rdiv; >> >> - if (hwdata->num > 5) >> + if (hwdata->num <= 5) >> reg = si5351_msynth_params_address(hwdata->num) + 2; >> else >> reg = SI5351_CLK6_7_OUTPUT_DIVIDER; >> -- >> 1.7.9.5 > Regards, Marek -- Marek Belisko Software Developer StreamUnlimited Engineering GmbH Gutheil Schodergasse 8-12 A-1100 Vienna, Austria Office: +421 267200087 e-mail: marek.belisko@streamunlimited.com http://www.streamunlimited.com Meet us at: IFA - Berlin, 6-11 September CEDIA - Denver, 25-28 September -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/