From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Jiri Slaby <jslaby@suse.cz>, jirislaby@gmail.com
Cc: linux-kernel@vger.kernel.org, Jeff Mahoney <jeffm@suse.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org
Subject: Re: [PATCH 13/15] chipidea: Allow user to select PCI/IMX options
In-Reply-To: <5193B0CB.9080608@suse.cz>
References: <1367936303-13386-1-git-send-email-jslaby@suse.cz> <1367936303-13386-13-git-send-email-jslaby@suse.cz> <87k3n9n8ln.fsf@ashishki-desk.ger.corp.intel.com> <5193B0CB.9080608@suse.cz>
User-Agent: Notmuch/0.12+187~ga2502b0 (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu)
Date: Thu, 16 May 2013 12:36:26 +0300
Message-ID: <87a9nvl10l.fsf@ashishki-desk.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2702
Lines: 67

Jiri Slaby <jslaby@suse.cz> writes:

> On 05/08/2013 11:07 AM, Alexander Shishkin wrote:
>> Jiri Slaby <jslaby@suse.cz> writes:
>> 
>>> From: Jeff Mahoney <jeffm@suse.com>
>>>
>>> The chipidea driver currently has needless ifneq rules in the makefile
>>> for things that should be config options.
>> 
>> Please elaborate on the "should be" part.
>> 
>>> This can be problematic,
>>> especially in the IMX case, since the OF_DEVICE dependency will be met
>>> on powerpc systems - which don't actually support the hardware via that
>>> method.
>> 
>> That's all right, but these things should still compile on powerpc and
>> get more compilation testing like that. On the other hand, if the
>> compilation does break, we're probably looking at a bug in ci13xxx_imx,
>> which needs fixing.
>> 
>>> This patch adds _PCI and _IMX config options to allow the user to
>>> select whether to build the modules.
>> 
>> I would really like to avoid unnecessary config options in the chipidea
>> driver, so my question is: is there a real bug or compilation breakage
>> that is triggered in the current state of things?
>> 
>>> +config USB_CHIPIDEA_PCI
>>> +	bool "ChipIdea PCI support"
>>> +	depends on PCI
>>> +	help
>>> +	  This option enables ChipIdea support on PCI.
>> 
>> I totally don't understand this: we have CONFIG_USB_CHIPIDEA and
>> CONFIG_PCI, which already enable chipidea support on PCI. This helps in
>> the case when you have both options enabled, but still don't want the
>> ci13xxx_pci module to be built, but it doesn't justify an extra option.
>
> Hi, the whole point of the patch is that there is no reason in building
> the imx part of the driver on powerpc, because ppc will never provide
> that of_device. So we are adding that option and disable that in suse
> completely by this patch plus a config option.

The benefit from compiling it on non-arm (or non-imx) architectures for
me is compilation testing. We don't have a whole lot of architectures
with CONFIG_OF so it's nice to give it a stretch.

If you really want to save space in your rpm package, I would suggest
you add a condition to Makefile (ifeq ($(ARCH),arm) or something like
that) instead of a Kconfig option. I would prefer at least to avoid the
unnecessary kconfig option creep.

> The PCI case is not necessarily needed, but follows the IMX case.

But then, if you want to disable both IMX and PCI you're better off
disabling the whole chipidea instead.

Thanks,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/