Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751476Ab3EPKNp (ORCPT ); Thu, 16 May 2013 06:13:45 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:65115 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751120Ab3EPKNm (ORCPT ); Thu, 16 May 2013 06:13:42 -0400 Date: Thu, 16 May 2013 11:12:00 +0100 From: Catalin Marinas To: Steven Rostedt Cc: Larry Finger , "zhangwei(Jovi)" , Masami Hiramatsu , LKML , Rusty Russell Subject: Re: V3.10-rc1 memory leak Message-ID: <20130516101200.GA3001@darko.cambridge.arm.com> References: <51912567.6090507@lwfinger.net> <1368558586.6828.53.camel@gandalf.local.home> <20130514203028.GA2997@MacBook-Pro.local> <5192A847.1000100@lwfinger.net> <1368566427.6828.58.camel@gandalf.local.home> <1368579423.6828.63.camel@gandalf.local.home> <20130515143719.GB1096@darko.cambridge.arm.com> <1368646381.6828.74.camel@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1368646381.6828.74.camel@gandalf.local.home> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1662 Lines: 40 On Wed, May 15, 2013 at 08:33:01PM +0100, Steven Rostedt wrote: > On Wed, 2013-05-15 at 15:37 +0100, Catalin Marinas wrote: > > > >From 0621c7e1909ea86bf8499a0ffe5ea59d1007ee8c Mon Sep 17 00:00:00 2001 > > From: Catalin Marinas > > Date: Wed, 15 May 2013 15:30:46 +0100 > > Subject: [PATCH] kmemleak: Scan the jump label module section > > > > Objects allocated in jump_label_add_module() are currently reported as > > leaks, though the pointers are stored in the module jump label section. > > This patch informs kmemleak that this section needs to be scanned. > > > > Signed-off-by: Catalin Marinas > > Reported-by: Steven Rostedt > > This didn't work. I still get the leak messages. But this change did: > > Instead of just picking data sections by name (names that start > with .data, .bss or .ref.data), use the section flags and scan all > sections that are allocated, writable and not executable. Which should > cover all sections of a module that might reference data. > > Signed-off-by: Steven Rostedt That's even better. I tested the two patches as well, added a subject and a bit of clean-up and pushed them to this branch: git://git.kernel.org/pub/scm/linux/kernel/git/cmarinas/linux-aarch64.git kmemleak Rusty, are you ok to take these or just ack and I'll push them to Linus. Thanks. -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/