Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752210Ab3EPKyn (ORCPT ); Thu, 16 May 2013 06:54:43 -0400 Received: from mail-we0-f175.google.com ([74.125.82.175]:40601 "EHLO mail-we0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751763Ab3EPKyl (ORCPT ); Thu, 16 May 2013 06:54:41 -0400 MIME-Version: 1.0 In-Reply-To: <5194B8DA.4080204@gmail.com> References: <1368622349-32185-1-git-send-email-prabhakar.csengg@gmail.com> <5194B8DA.4080204@gmail.com> From: Prabhakar Lad Date: Thu, 16 May 2013 16:24:19 +0530 Message-ID: Subject: Re: [PATCH RFC] media: OF: add field-active and sync-on-green endpoint properties To: Sylwester Nawrocki Cc: LMML , LKML , DLOS , Hans Verkuil , Laurent Pinchart , Mauro Carvalho Chehab , Guennadi Liakhovetski , Sylwester Nawrocki , Sakari Ailus , Grant Likely , Rob Herring , Rob Landley , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, Kyungmin Park Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1844 Lines: 56 Hi Sylwester, Thanks for the review. On Thu, May 16, 2013 at 4:15 PM, Sylwester Nawrocki wrote: > On 05/15/2013 02:52 PM, Lad Prabhakar wrote: >> >> diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt >> b/Documentation/devicetree/bindings/media/video-interfaces.txt >> index e022d2d..6bf87d0 100644 >> --- a/Documentation/devicetree/bindings/media/video-interfaces.txt >> +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt >> @@ -101,6 +101,10 @@ Optional endpoint properties >> array contains only one entry. >> - clock-noncontinuous: a boolean property to allow MIPI CSI-2 >> non-continuous >> clock mode. >> +-field-active: a boolean property indicating active high filed ID output >> + polarity is inverted. > > > You can drop this property and use the existing 'field-even-active' property > instead. > OK > >> +-sync-on-green: a boolean property indicating to sync with the green >> signal in >> + RGB. > > >> diff --git a/include/media/v4l2-mediabus.h b/include/media/v4l2-mediabus.h >> index 83ae07e..b95553d 100644 >> --- a/include/media/v4l2-mediabus.h >> +++ b/include/media/v4l2-mediabus.h >> @@ -40,6 +40,8 @@ >> #define V4L2_MBUS_FIELD_EVEN_HIGH (1<< 10) >> /* FIELD = 1/0 - Field1 (odd)/Field2 (even) */ >> #define V4L2_MBUS_FIELD_EVEN_LOW (1<< 11) >> +#define V4L2_MBUS_FIELD_ACTIVE (1<< 12) >> +#define V4L2_MBUS_SOG (1<< 13) > > > How about V4L2_MBUS_SYNC_ON_GREEN ? > OK makes it more readable. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/