Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754368Ab3EPNuF (ORCPT ); Thu, 16 May 2013 09:50:05 -0400 Received: from mail-qe0-f50.google.com ([209.85.128.50]:46800 "EHLO mail-qe0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754289Ab3EPNuC (ORCPT ); Thu, 16 May 2013 09:50:02 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Thu, 16 May 2013 09:50:01 -0400 Message-ID: Subject: Re: [PATCH v3 6/9] radeon: Switch to arch_phys_wc_add and add a missing ..._del From: Jerome Glisse To: Andy Lutomirski Cc: Alex Deucher , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Daniel Vetter , Dave Airlie Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1657 Lines: 39 On Wed, May 15, 2013 at 2:22 PM, Andy Lutomirski wrote: > On Wed, May 15, 2013 at 7:49 AM, Jerome Glisse wrote: >> On Tue, May 14, 2013 at 5:35 PM, Andy Lutomirski wrote: >>> On Tue, May 14, 2013 at 6:37 AM, Jerome Glisse wrote: >>>> On Tue, May 14, 2013 at 8:58 AM, Alex Deucher wrote: >>>>> On Mon, May 13, 2013 at 7:58 PM, Andy Lutomirski wrote: >>>>>> Reviewed-by: Daniel Vetter >>>>>> Signed-off-by: Andy Lutomirski >>>>> >>>>> Reviewed-by: Alex Deucher >>>> >>>> I believe it will break something but we could deal with the fallout >>>> once it happens. >>> >>> FWIW, I'm running with this code on my machine right now using the >>> radeon driver. Everything seems fine. If I build without MTRRs and >>> without PAT, though, graphics are slow (as expected). So I think >>> everything's okay. >>> >>> --Andy >> >> I am worried on p4 where i last see issue with that notably with agp. > > Do you remember any details? It looks like PAT is enabled on Pentium > 4 (i.e. famliy 0xF). > > --Andy No i don't, i think it was some pat errata on those about non real ram address and with agp. Memory is fuzzy. I might have time in couple of week to plug back my p4 and see how it behave. Cheers, Jerome -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/