Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753279Ab3EPQIK (ORCPT ); Thu, 16 May 2013 12:08:10 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:58384 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752425Ab3EPQII (ORCPT ); Thu, 16 May 2013 12:08:08 -0400 Message-ID: <5195045A.5080507@canonical.com> Date: Thu, 16 May 2013 12:07:54 -0400 From: Joseph Salisbury User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130404 Thunderbird/17.0.5 MIME-Version: 1.0 To: Laurent Pinchart CC: linux-kernel@vger.kernel.org, mchehab@redhat.com, linux-media@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/1] [media] uvcvideo: quirk PROBE_DEF for Alienware X51 OmniVision webcam References: <1368650328-21128-1-git-send-email-joseph.salisbury@canonical.com> <4475290.i8RRTUStdI@avalon> In-Reply-To: <4475290.i8RRTUStdI@avalon> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2975 Lines: 75 On 05/16/2013 08:03 AM, Laurent Pinchart wrote: > Hi Joseph, > > Thank you for the patch. Thanks for the feedback. > > On Wednesday 15 May 2013 16:38:48 joseph.salisbury@canonical.com wrote: >> From: Joseph Salisbury >> >> BugLink: http://bugs.launchpad.net/bugs/1180409 >> >> OminiVision webcam 0x05a9:0x2643 needs the same UVC_QUIRK_PROBE_DEF as other >> OmniVision models to work properly. >> >> Cc: Laurent Pinchart >> Cc: Mauro Carvalho Chehab >> Cc: linux-media@vger.kernel.org >> Cc: stable@vger.kernel.org >> Signed-off-by: Joseph Salisbury > There's already a 05a9:2643 webcam model, found in a Dell monitor, that has > been reported to work properly without the UVC_QUIRK_PROBE_DEF. Enabling the > quirk shouldn't hurt, but I'd like to check differences between the two > devices. Could you please send me the output of > > lsusb -v -d 05a9:2643 > > (running as root if possible) ? The lsusb output can be seen at: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1180409/comments/10/+download I can also send this to you as an attachment if needed. > >> --- >> drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/drivers/media/usb/uvc/uvc_driver.c >> b/drivers/media/usb/uvc/uvc_driver.c index 5dbefa6..411682c 100644 >> --- a/drivers/media/usb/uvc/uvc_driver.c >> +++ b/drivers/media/usb/uvc/uvc_driver.c >> @@ -2163,6 +2163,15 @@ static struct usb_device_id uvc_ids[] = { >> .bInterfaceSubClass = 1, >> .bInterfaceProtocol = 0, >> .driver_info = UVC_QUIRK_PROBE_DEF }, >> + /* Alienware X51*/ >> + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE >> + | USB_DEVICE_ID_MATCH_INT_INFO, >> + .idVendor = 0x05a9, >> + .idProduct = 0x2643, >> + .bInterfaceClass = USB_CLASS_VIDEO, >> + .bInterfaceSubClass = 1, >> + .bInterfaceProtocol = 0, >> + .driver_info = UVC_QUIRK_PROBE_DEF }, > Your mailer messed up formatting. As the patch is small I've fixed it > manually, but please make sure to use a proper mail client next time. I advise > using git-send-email to send patches. Thanks. I did in fact use git-send-email, which is what I use to send all patches. Can you point out the bad formatting. Is it that '| USB_DEVICE_ID_MATCH_INT_INFO,' was not indented? If so, I'll investigate why that happened. > >> /* Apple Built-In iSight */ >> { .match_flags = USB_DEVICE_ID_MATCH_DEVICE >> >> | USB_DEVICE_ID_MATCH_INT_INFO, Thanks again for reviewing this patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/