Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755252Ab3EPXKc (ORCPT ); Thu, 16 May 2013 19:10:32 -0400 Received: from mail-lb0-f175.google.com ([209.85.217.175]:35074 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754728Ab3EPXKa (ORCPT ); Thu, 16 May 2013 19:10:30 -0400 MIME-Version: 1.0 In-Reply-To: <1475116.qtX3b3bLWZ@flatron> References: <1368724352-10849-1-git-send-email-dianders@chromium.org> <2099430.Q29j0K3hPy@flatron> <201305170030.39266.heiko@sntech.de> <1475116.qtX3b3bLWZ@flatron> Date: Thu, 16 May 2013 16:10:28 -0700 X-Google-Sender-Auth: AcLU3YupP2E6HCw2vGrelPY9SOY Message-ID: Subject: Re: [PATCH 1/2] pinctrl: samsung: fix suspend/resume functionality From: Doug Anderson To: Tomasz Figa Cc: =?ISO-8859-1?Q?Heiko_St=FCbner?= , Kukjin Kim , Olof Johansson , Stephen Warren , Thomas Abraham , Linus Walleij , Prathyush K , linux-samsung-soc , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1195 Lines: 29 Tomasz, On Thu, May 16, 2013 at 3:56 PM, Tomasz Figa wrote: > Seems like I need some sleep, as I'm already starting to overlook large > blobs of code. > > Originally, GPIO suspend/resume handlers have been configured in > drivers/gpio/gpio-samsung.c, by setting pm field of samsung_gpio_chip > struct to point to appropriate samsung_gpio_pm struct, which contains > pointers to save and resume callbacks. > > In result, samsung_gpio_pm_2bit_* or samsung_gpio_pm_4bit_* have been > used, depending on bank type, on all SoCs. > > Now since the documentation states that wake-up reset doesn't reset GPIO > registers (at least on S3C2440 and S3C2416), I wonder what is the correct > way of handling them. If state of these registers isn't lost on those SoCs then running the save/restore shouldn't _hurt_ though, right? If you can run the old GPIO code on one of those systems and do a suspend/resume you could check... -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/