Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755283Ab3EPXtM (ORCPT ); Thu, 16 May 2013 19:49:12 -0400 Received: from mail-lb0-f171.google.com ([209.85.217.171]:42096 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754913Ab3EPXtH (ORCPT ); Thu, 16 May 2013 19:49:07 -0400 MIME-Version: 1.0 In-Reply-To: <8199419.ooBeNM55eX@flatron> References: <1368724352-10849-1-git-send-email-dianders@chromium.org> <1483058.pKLP2TAAG6@flatron> <8199419.ooBeNM55eX@flatron> Date: Thu, 16 May 2013 16:49:05 -0700 X-Google-Sender-Auth: qK1qC6foCsMPtsBa4x4-nE27uaM Message-ID: Subject: Re: [PATCH 2/2] pinctrl: exynos: fix eint wakeup by using irq_set_wake() From: Doug Anderson To: Tomasz Figa Cc: Kukjin Kim , Olof Johansson , Stephen Warren , Thomas Abraham , Linus Walleij , Prathyush K , linux-samsung-soc , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1909 Lines: 44 Tomasz, On Thu, May 16, 2013 at 3:37 PM, Tomasz Figa wrote: > Well, to make long story short, including headers from plat/ and mach/ > from files outside plat/ or mach/ is no longer valid with > CONFIG_MULTIPLATFORM, because more than one plat and/or mach can be > enabled at the same time. In addition to this, care must be taken for code > to not break platforms other than written for, when compiled into the > resulting kernel. Right. That makes sense. That's also why it would be a bit of a longshot for me to get this done right now. I'd imagine that there would be a number of changes to the samsung pm infrastructure that are needed to make this work and I don't have all of those in my tree right now. We've already picked back a lot to 3.8, but multiplatform seems too much. >> Perhaps for this patch it makes more sense for you to post your >> version and I can review it? We may end up just keeping our version >> of this patch for 3.8 and pick up yours when we do our next rebase. >> Does that sound OK? > > Fine. I will also send a patch adding save and restore for several EINT > registers that need it. OK, sounds good. I was trying to figure out why we didn't seem to have those in our 3.4 stuff and that it seems to work without saving/restoring. I assumed that maybe higher level code was masking/unmasking interrupts but didn't dig. > Since EINT handling is highly SoC-specific (i.e. done in pinctrl-exynos, > not pinctrl-samsung), such assumption wouldn't be a problem. Let me see > how I solved this problem in my version tomorrow at work. Fair enough. :) Looking forward to seeing your patch! -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/