Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755296Ab3EPXzb (ORCPT ); Thu, 16 May 2013 19:55:31 -0400 Received: from mail-lb0-f176.google.com ([209.85.217.176]:57799 "EHLO mail-lb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752045Ab3EPXza (ORCPT ); Thu, 16 May 2013 19:55:30 -0400 MIME-Version: 1.0 In-Reply-To: References: <1368724352-10849-1-git-send-email-dianders@chromium.org> <2099430.Q29j0K3hPy@flatron> <201305170030.39266.heiko@sntech.de> <1475116.qtX3b3bLWZ@flatron> Date: Thu, 16 May 2013 16:55:28 -0700 X-Google-Sender-Auth: HuQaRhyqK0LOdz-eiMgaSHxFmws Message-ID: Subject: Re: [PATCH 1/2] pinctrl: samsung: fix suspend/resume functionality From: Doug Anderson To: Tomasz Figa Cc: =?ISO-8859-1?Q?Heiko_St=FCbner?= , Kukjin Kim , Olof Johansson , Stephen Warren , Thomas Abraham , Linus Walleij , Prathyush K , linux-samsung-soc , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1176 Lines: 29 Tomasz, On Thu, May 16, 2013 at 4:10 PM, Doug Anderson wrote: > If state of these registers isn't lost on those SoCs then running the > save/restore shouldn't _hurt_ though, right? If you can run the old > GPIO code on one of those systems and do a suspend/resume you could > check... I think it's been too long of a day for me, too. I just thought about this and realized that there is no "powerdown" registers for the GPX banks on exynos5250. ...and they don't lose their state at sleep! ...so maybe a reasonable thing to do would be to skip save/restore in any case where there are no powerdown registers? You can see a printout in my case: [ 412.840000] gpx0 @ f004ac00 (con 0x30000110 => 0x30000110) [ 412.840000] gpx1 @ f004ac20 (con 0x1f10ff10 => 0x1f10ff10) [ 412.840000] gpx2 @ f004ac40 (con 0x1f000f0f => 0x1f000f0f) [ 412.840000] gpx3 @ f004ac60 (con 0x00f00f01 => 0x00f00f01) -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/