Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755337Ab3EQBOq (ORCPT ); Thu, 16 May 2013 21:14:46 -0400 Received: from ozlabs.org ([203.10.76.45]:34574 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755026Ab3EQBOm (ORCPT ); Thu, 16 May 2013 21:14:42 -0400 From: Rusty Russell To: "Michael S. Tsirkin" , kvm@vger.kernel.org Cc: Stephen Hemminger , Jason Wang , Paolo Bonzini , "Paul E. McKenney" , David Howells , Dave Jones , Thomas Gleixner , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] virtio_pci: fix macro exported in uapi In-Reply-To: <20130516164446.GA32007@redhat.com> References: <20130516164446.GA32007@redhat.com> User-Agent: Notmuch/0.15.2+81~gd2c8818 (http://notmuchmail.org) Emacs/23.4.1 (i686-pc-linux-gnu) Date: Fri, 17 May 2013 09:39:07 +0930 Message-ID: <87wqqy8o2k.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 727 Lines: 21 "Michael S. Tsirkin" writes: > macro VIRTIO_PCI_CONFIG except in the unlikely event userspace > actually has a structure with a field named msix_enabled. > Get the msix_enabled by value instead, to make it useful > for userspace. > > Signed-off-by: Michael S. Tsirkin Macro still isn't usable, because userspace can't know whether it's the new or old. We need to either remove it from UAPI, or rename it to VIRTIO_PCI_CONFIG_OFF. Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/