Date: Thu, 16 May 2013 17:34:59 -0700
From: Greg KH <greg@kroah.com>
To: Libo Chen <libo.chen@huawei.com>
Cc: stern@rowland.harvard.edu, grant.likely@linaro.org,
        rob.herring@calxeda.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
        lizefan@huawei.com, Libo Chen <chenlibo.3@gmail.com>
Subject: Re: [PATCH 3/4] usb: ohci: fix goto wrong tag in err case
Message-ID: <20130517003459.GB10235@kroah.com>
References: <1368075491-38728-1-git-send-email-libo.chen@huawei.com>
 <1368075491-38728-4-git-send-email-libo.chen@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1368075491-38728-4-git-send-email-libo.chen@huawei.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1038
Lines: 32

On Thu, May 09, 2013 at 12:58:10PM +0800, Libo Chen wrote:
> From: Libo Chen <chenlibo.3@gmail.com>
> 
> fix goto wrong tag in usb_hcd_nxp_probe
> 
> Signed-off-by: Libo Chen <libo.chen@huawei.com>
> ---
>  drivers/usb/host/ohci-nxp.c |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c
> index f4988fb..eb294a9 100644
> --- a/drivers/usb/host/ohci-nxp.c
> +++ b/drivers/usb/host/ohci-nxp.c
> @@ -234,7 +234,7 @@ static int usb_hcd_nxp_probe(struct platform_device *pdev)
>  	if (usb_disabled()) {
>  		dev_err(&pdev->dev, "USB is disabled\n");
>  		ret = -ENODEV;
> -		goto out;
> +		goto out1;

Please fix this up to use better error case names so this does not
happen again.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/