Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754615Ab3EQE7R (ORCPT ); Fri, 17 May 2013 00:59:17 -0400 Received: from mail-vc0-f171.google.com ([209.85.220.171]:53402 "EHLO mail-vc0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754301Ab3EQE7N (ORCPT ); Fri, 17 May 2013 00:59:13 -0400 MIME-Version: 1.0 In-Reply-To: <5194DC6A.8080609@cogentembedded.com> References: <1368687502-15551-1-git-send-email-prabhakar.csengg@gmail.com> <5194DC6A.8080609@cogentembedded.com> From: Prabhakar Lad Date: Fri, 17 May 2013 10:28:52 +0530 Message-ID: Subject: Re: [PATCH] ARM: davinci: dma: Convert to devm_* api To: Sergei Shtylyov Cc: Sekhar Nori , DLOS , LAK , LKML Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2248 Lines: 81 Hi Sergei, Thanks for the review. On Thu, May 16, 2013 at 6:47 PM, Sergei Shtylyov wrote: > Hello. > > > On 16-05-2013 10:58, Lad Prabhakar wrote: > >> From: Lad, Prabhakar > > >> Use devm_ioremap_resource instead of reques_mem_region()/ioremap() and >> devm_request_irq() instead of request_irq(). > > >> This ensures more consistent error values and simplifies error paths. > > >> Signed-off-by: Lad, Prabhakar >> --- >> NOte:- Boot tested on Logic-PD OMAP-L138 EVM > > >> arch/arm/mach-davinci/dma.c | 63 >> ++++++++++++++++-------------------------- >> 1 files changed, 24 insertions(+), 39 deletions(-) > > >> diff --git a/arch/arm/mach-davinci/dma.c b/arch/arm/mach-davinci/dma.c >> index 45b7c71..aeda496 100644 >> --- a/arch/arm/mach-davinci/dma.c >> +++ b/arch/arm/mach-davinci/dma.c > > [...] > >> @@ -1422,25 +1421,16 @@ static int __init edma_probe(struct >> platform_device *pdev) >> found = 1; >> } >> >> - len[j] = resource_size(r[j]); >> - >> - r[j] = request_mem_region(r[j]->start, len[j], >> - dev_name(&pdev->dev)); >> - if (!r[j]) { >> - status = -EBUSY; >> - goto fail1; >> - } >> - >> - edmacc_regs_base[j] = ioremap(r[j]->start, len[j]); >> - if (!edmacc_regs_base[j]) { >> + edmacc_regs_base[j] = devm_ioremap_resource(&pdev->dev, >> r[j]); >> + if (IS_ERR(edmacc_regs_base[j])) { >> status = -EBUSY; > > > And you call that "more consistent error values"? Why not: > > status = PTR_ERR(edmacc_regs_base[j]); > Yes missed it will fix it in v2. > >> edma_cc[j] = kzalloc(sizeof(struct edma), GFP_KERNEL); > > > Maybe it's worth using devm_kzalloc() too? > OK Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/